common: Fix BufferViewConfig upgrade defaults
authorShane Synan <digitalcircuit36939@gmail.com>
Thu, 12 Jul 2018 01:13:22 +0000 (20:13 -0500)
committerManuel Nickschas <sputnick@quassel-irc.org>
Thu, 12 Jul 2018 22:37:49 +0000 (00:37 +0200)
Fix initialization of default values when upgrading BufferViewConfig.
This solves the issue of showSearch() being set to true on upgrade
despite having the default of false.

Search doesn't usually need shown as the activate shortcut will make
it temporarily appear.

Details: When loading a buffer from configuration, the
"fromVariantMap(properties);" path was taken.  As this side lacked
the initialization, defaults weren't set for newly-added values.

Thankfully, it really is just this simple (fingers crossed).

Add some documentation love, too.


No differences found