common: Fix BufferViewConfig upgrade defaults
authorShane Synan <digitalcircuit36939@gmail.com>
Thu, 12 Jul 2018 01:13:22 +0000 (20:13 -0500)
committerManuel Nickschas <sputnick@quassel-irc.org>
Thu, 12 Jul 2018 22:37:49 +0000 (00:37 +0200)
commite9c0076ab1da4d613cf0ef97adbb1f45fed13d47
treea478857dddaf5662dc2053cef333303cf3120e87
parent70955828d6ffab8c39435fe48a923d0c7dbbb678
common: Fix BufferViewConfig upgrade defaults

Fix initialization of default values when upgrading BufferViewConfig.
This solves the issue of showSearch() being set to true on upgrade
despite having the default of false.

Search doesn't usually need shown as the activate shortcut will make
it temporarily appear.

Details: When loading a buffer from configuration, the
"fromVariantMap(properties);" path was taken.  As this side lacked
the initialization, defaults weren't set for newly-added values.

Thankfully, it really is just this simple (fingers crossed).

Add some documentation love, too.
src/common/bufferviewconfig.cpp
src/common/bufferviewconfig.h