cmake: Build shared libraries (DLLs) on Windows
authorManuel Nickschas <sputnick@quassel-irc.org>
Sun, 2 Sep 2018 21:29:43 +0000 (23:29 +0200)
committerManuel Nickschas <sputnick@quassel-irc.org>
Sun, 18 Nov 2018 10:06:43 +0000 (11:06 +0100)
Since symbols are now properly marked for export, we can finally
enable the building of DLLs on Windows.

cmake/QuasselMacros.cmake

index 8ad37f7..3af589a 100644 (file)
@@ -45,9 +45,7 @@ function(quassel_add_module _module)
     string(REPLACE "::" "_" target ${target})
     string(REPLACE "_" "-" output_name ${target})
 
-    # On Windows, building shared libraries requires export headers.
-    # Let's bother with that later.
-    if (ARG_STATIC OR WIN32)
+    if (ARG_STATIC)
         set(buildmode STATIC)
     else()
         set(buildmode SHARED)