Fixed possible segfault in IrcChannel::isKnownUser()
authorMarcus Eggenberger <egs@quassel-irc.org>
Fri, 7 Dec 2007 15:28:57 +0000 (15:28 +0000)
committerMarcus Eggenberger <egs@quassel-irc.org>
Fri, 7 Dec 2007 15:28:57 +0000 (15:28 +0000)
src/common/ircchannel.cpp

index 2bcb8ca..47082dd 100644 (file)
@@ -49,19 +49,17 @@ IrcChannel::~IrcChannel() {
 //  PUBLIC:
 // ====================
 bool IrcChannel::isKnownUser(IrcUser *ircuser) const {
-  bool isknown = true;
-
   if(ircuser == 0) {
     qWarning() << "Channel" << name() << "received IrcUser Nullpointer!";
-    isknown = false;
+    return false;
   }
   
   if(!_userModes.contains(ircuser)) {
     qWarning() << "Channel" << name() << "received data for unknown User" << ircuser->nick();
-    isknown = false;
+    return false;
   }
-  
-  return isknown;
+
+  return true;
 }
 
 bool IrcChannel::isValidChannelUserMode(const QString &mode) const {