From: Marcus Eggenberger <egs@quassel-irc.org>
Date: Fri, 7 Dec 2007 15:28:57 +0000 (+0000)
Subject: Fixed possible segfault in IrcChannel::isKnownUser()
X-Git-Tag: 0.1.0~36
X-Git-Url: https://git.quassel-irc.org/?p=quassel.git;a=commitdiff_plain;h=3914857f784637e678a8ea029b338228ff67d94e;hp=dada01a6ab8b980e28eb486bd5dba8091f975bd6

Fixed possible segfault in IrcChannel::isKnownUser()
---

diff --git a/src/common/ircchannel.cpp b/src/common/ircchannel.cpp
index 2bcb8ca0..47082dd6 100644
--- a/src/common/ircchannel.cpp
+++ b/src/common/ircchannel.cpp
@@ -49,19 +49,17 @@ IrcChannel::~IrcChannel() {
 //  PUBLIC:
 // ====================
 bool IrcChannel::isKnownUser(IrcUser *ircuser) const {
-  bool isknown = true;
-
   if(ircuser == 0) {
     qWarning() << "Channel" << name() << "received IrcUser Nullpointer!";
-    isknown = false;
+    return false;
   }
   
   if(!_userModes.contains(ircuser)) {
     qWarning() << "Channel" << name() << "received data for unknown User" << ircuser->nick();
-    isknown = false;
+    return false;
   }
-  
-  return isknown;
+
+  return true;
 }
 
 bool IrcChannel::isValidChannelUserMode(const QString &mode) const {