client: ChatViewSettings check before reload Qss
authorShane Synan <digitalcircuit36939@gmail.com>
Thu, 14 Jun 2018 05:33:41 +0000 (00:33 -0500)
committerManuel Nickschas <sputnick@quassel-irc.org>
Sat, 16 Jun 2018 19:20:42 +0000 (21:20 +0200)
Check if Qt stylesheet needs regenerating before regenerating and
reloading the stylesheet, only doing it if the font settings change.
Everything else doesn't modify the stylesheet, speeding up changing
those settings when font is not changed.

src/qtui/settingspages/chatviewsettingspage.cpp

index c3fd8ae..f1a074f 100644 (file)
@@ -76,9 +76,15 @@ void ChatViewSettingsPage::initSenderPrefixComboBox()
 
 void ChatViewSettingsPage::save()
 {
+    bool needsStyleReload = SettingsPage::hasChanged(ui.customChatViewFont)
+            || SettingsPage::hasChanged(ui.chatViewFont);
+
     // Save the general settings
     SettingsPage::save();
-    // Update the stylesheet in case fonts are changed
-    QtUi::style()->generateSettingsQss();
-    QtUi::style()->reload();
+
+    // Update the stylesheet if fonts are changed
+    if (needsStyleReload) {
+        QtUi::style()->generateSettingsQss();
+        QtUi::style()->reload();
+    }
 }