client: Clarify QKeySequence::Quit matter in docs
authorShane Synan <digitalcircuit36939@gmail.com>
Fri, 1 Jun 2018 00:20:00 +0000 (19:20 -0500)
committerManuel Nickschas <sputnick@quassel-irc.org>
Wed, 6 Jun 2018 18:15:42 +0000 (20:15 +0200)
QKeySequence::Quit does not set "Ctrl-Q" on Windows, while many
Windows programs use that to provide Quit, including Quassel IRC.

Modify the comment to explain the situation.

See https://doc.qt.io/qt-5/qkeysequence.html

src/qtui/mainwin.cpp

index 14644fb..8eefba1 100644 (file)
@@ -402,7 +402,11 @@ void MainWin::setupActions()
             this, SLOT(showCoreInfoDlg())));
     coll->addAction("ConfigureNetworks", new Action(QIcon::fromTheme("configure"), tr("Configure &Networks..."), coll,
             this, SLOT(on_actionConfigureNetworks_triggered())));
-    // FIXME: use QKeySequence::Quit once we depend on Qt 4.6
+    // QKeySequence::Quit was added in Qt 4.6, and could be used instead.  However, that key
+    // sequence is empty by default on Windows, which would remove Ctrl-Q to quit.  It may be best
+    // to just keep it this way.
+    //
+    // See https://doc.qt.io/qt-5/qkeysequence.html
     coll->addAction("Quit", new Action(QIcon::fromTheme("application-exit"), tr("&Quit"), coll,
             this, SLOT(quit()), Qt::CTRL + Qt::Key_Q));