qa: Resolve Qt deprecation warnings - default-construct QFlags

Empty QFlags should not be created by giving a nullptr to the ctor,
but by simply using the default ctor instead.

Resolves a deprecation warning that was introduced in Qt 5.15.

diff --git a/src/client/treemodel.cpp b/src/client/treemodel.cpp
index 006434c..3e243a4 100644 (file)
--- a/src/client/treemodel.cpp
+++ b/src/client/treemodel.cpp
@@ -45,7 +45,6 @@ private:
 AbstractTreeItem::AbstractTreeItem(AbstractTreeItem* parent)
     : QObject(parent)
     , _flags(Qt::ItemIsSelectable | Qt::ItemIsEnabled)
-    , _treeItemFlags(nullptr)
 {}
 
 bool AbstractTreeItem::newChild(AbstractTreeItem* item)
@@ -102,7 +101,7 @@ void AbstractTreeItem::removeAllChilds()
     childIter = _childItems.begin();
     while (childIter != _childItems.end()) {
         child = *childIter;
-        child->setTreeItemFlags(nullptr);  // disable self deletion, as this would only fuck up consitency and the child gets deleted anyways
+        child->setTreeItemFlags({});  // disable self deletion, as this would only fuck up consitency and the child gets deleted anyways
         child->removeAllChilds();
         ++childIter;
     }

diff --git a/src/client/treemodel.h b/src/client/treemodel.h
index 431f2b5..3c6ce91 100644 (file)
--- a/src/client/treemodel.h
+++ b/src/client/treemodel.h
@@ -87,8 +87,8 @@ protected:
 
 private:
     QList<AbstractTreeItem*> _childItems;
-    Qt::ItemFlags _flags;
-    TreeItemFlags _treeItemFlags;
+    Qt::ItemFlags _flags{};
+    TreeItemFlags _treeItemFlags{};
 
     void removeChildLater(AbstractTreeItem* child);
     inline void checkForDeletion()

diff --git a/src/qtui/ircconnectionwizard.h b/src/qtui/ircconnectionwizard.h
index 2c67a06..1db66cc 100644 (file)
--- a/src/qtui/ircconnectionwizard.h
+++ b/src/qtui/ircconnectionwizard.h
@@ -30,7 +30,7 @@ class IrcConnectionWizard : public QWizard
     Q_OBJECT
 
 public:
-    IrcConnectionWizard(QWidget* parent = nullptr, Qt::WindowFlags flags = nullptr);
+    IrcConnectionWizard(QWidget* parent = nullptr, Qt::WindowFlags flags = {});
 
     static QWizardPage* createIntroductionPage(QWidget* parent = nullptr);
 

diff --git a/src/qtui/nicklistwidget.cpp b/src/qtui/nicklistwidget.cpp
index 5ab410b..aae3288 100644 (file)
--- a/src/qtui/nicklistwidget.cpp
+++ b/src/qtui/nicklistwidget.cpp
@@ -238,7 +238,7 @@ NickListDock::NickListDock(const QString& title, QWidget* parent)
 void NickListDock::setLocked(bool locked)
 {
     if (locked) {
-        setFeatures(nullptr);
+        setFeatures({});
     }
     else {
         setFeatures(QDockWidget::DockWidgetClosable | QDockWidget::DockWidgetMovable | QDockWidget::DockWidgetFloatable);

diff --git a/src/qtui/verticaldock.h b/src/qtui/verticaldock.h
index 0a6ba79..703b47c 100644 (file)
--- a/src/qtui/verticaldock.h
+++ b/src/qtui/verticaldock.h
@@ -59,8 +59,8 @@ class VerticalDock : public QDockWidget
     Q_OBJECT
 
 public:
-    VerticalDock(const QString& title, QWidget* parent = nullptr, Qt::WindowFlags flags = nullptr);
-    VerticalDock(QWidget* parent = nullptr, Qt::WindowFlags flags = nullptr);
+    VerticalDock(const QString& title, QWidget* parent = nullptr, Qt::WindowFlags flags = {});
+    VerticalDock(QWidget* parent = nullptr, Qt::WindowFlags flags = {});
 
     void showTitle(bool show);
     void setDefaultTitleWidget();

diff --git a/src/uisupport/bufferview.cpp b/src/uisupport/bufferview.cpp
index f5db3e2..3a2be71 100644 (file)
--- a/src/uisupport/bufferview.cpp
+++ b/src/uisupport/bufferview.cpp
@@ -728,7 +728,7 @@ BufferViewDock::BufferViewDock(BufferViewConfig* config, QWidget* parent)
 void BufferViewDock::setLocked(bool locked)
 {
     if (locked) {
-        setFeatures(nullptr);
+        setFeatures({});
     }
     else {
         setFeatures(QDockWidget::DockWidgetClosable | QDockWidget::DockWidgetMovable | QDockWidget::DockWidgetFloatable);