cmake: Build Windows icon resource again
authorManuel Nickschas <sputnick@quassel-irc.org>
Tue, 21 Aug 2018 22:29:17 +0000 (00:29 +0200)
committerManuel Nickschas <sputnick@quassel-irc.org>
Sun, 18 Nov 2018 10:06:43 +0000 (11:06 +0100)
Building the Windows resource got lost while refactoring the build
system, so bring it back.

pics/CMakeLists.txt
src/main/CMakeLists.txt

index 0cd43f6..6490ad1 100644 (file)
@@ -1,20 +1,5 @@
 # pics/ contains non-themed icons and other graphical resources
 
-if(WIN32)
-  if(MINGW)
-    find_program(WINDRES_EXECUTABLE NAMES windres)
-    if(WINDRES_EXECUTABLE)
-      exec_program(windres
-              ARGS "-i ${CMAKE_CURRENT_SOURCE_DIR}/win32.rc"
-                   "-o ${CMAKE_CURRENT_BINARY_DIR}/win32.o"
-                   "--include-dir=${CMAKE_CURRENT_SOURCE_DIR}")
-      set(COMMON_DEPS ${COMMON_DEPS} ${CMAKE_CURRENT_BINARY_DIR}/win32.o PARENT_SCOPE)
-    endif()
-  else()
-    set(COMMON_DEPS ${COMMON_DEPS} ${CMAKE_CURRENT_SOURCE_DIR}/win32.rc PARENT_SCOPE)
-  endif()
-endif()
-
 if (WANT_MONO OR WANT_QTCLIENT)
     quassel_add_resource(Pics PREFIX pics PATTERNS
         kde-vdg.png
index 0367467..b8a4140 100644 (file)
@@ -21,14 +21,32 @@ if (WITH_BUNDLED_ICONS)
     set_property(SOURCE main.cpp APPEND PROPERTY COMPILE_DEFINITIONS WITH_BUNDLED_ICONS)
 endif()
 
+# Windows icon resource
+if(WIN32)
+    if(MINGW)
+        find_program(WINDRES_EXECUTABLE NAMES windres)
+        if(WINDRES_EXECUTABLE)
+            exec_program(windres
+                ARGS "-i ${CMAKE_SOURCE_DIR}/pics/win32.rc"
+                     "-o ${CMAKE_CURRENT_BINARY_DIR}/win32.o"
+                     "--include-dir=${CMAKE_SOURCE_DIR}/pics"
+                )
+            set(WIN_RC ${CMAKE_CURRENT_BINARY_DIR}/win32.o)
+        endif()
+    else()
+        set(WIN_RC ${CMAKE_SOURCE_DIR}/pics/win32.rc)
+    endif()
+endif()
+
+
 # Build the executables
 if (WANT_CORE)
-    add_executable(quasselcore main.cpp)
+    add_executable(quasselcore main.cpp ${WIN_RC})
     setup_executable(quasselcore -DBUILD_CORE Qt5::Core Quassel::Core)
 endif()
 
 if (WANT_CLIENT OR WANT_QTCLIENT)
-    add_executable(quasselclient WIN32 main.cpp)
+    add_executable(quasselclient WIN32 main.cpp ${WIN_RC})
     setup_executable(quasselclient -DBUILD_QTUI Qt5::Core Qt5::Gui Quassel::QtUi)
     if (WITH_KDE)
         target_link_libraries(quasselclient PRIVATE KF5::CoreAddons)
@@ -36,7 +54,7 @@ if (WANT_CLIENT OR WANT_QTCLIENT)
 endif()
 
 if (WANT_MONO)
-    add_executable(quassel WIN32 main.cpp monoapplication.cpp)
+    add_executable(quassel WIN32 main.cpp monoapplication.cpp ${WIN_RC})
     setup_executable(quassel -DBUILD_MONO Qt5::Core Qt5::Gui Quassel::Core Quassel::QtUi)
     if (WITH_KDE)
         target_link_libraries(quassel PRIVATE KF5::CoreAddons)