core: Use IrcTags::SERVER_TIME for server-time tag
authorShane Synan <digitalcircuit36939@gmail.com>
Tue, 21 Jul 2020 00:06:32 +0000 (20:06 -0400)
committerManuel Nickschas <sputnick@quassel-irc.org>
Sat, 28 Nov 2020 12:42:31 +0000 (13:42 +0100)
Fixup IRCv3 "server-time" support to use the provided
IrcTags::SERVER_TIME tag, rather than creating a bespoke IrcTagKey
during parsing.  This shouldn't result in any functionality changes,
but it helps avoid typos with any future changes.

This cleans up changes in the past commit
e38846f054ad1766f2e91992a57bbaffd33c7c06

src/core/ircparser.cpp

index 3be0a3f..3bd8691 100644 (file)
@@ -119,14 +119,13 @@ void IrcParser::processNetworkIncoming(NetworkDataEvent* e)
         qDebug() << "IRC net" << net->networkId() << "<<" << tags << prefix << cmd << params;
     }
 
-    IrcTagKey serverTimeTag{"", "time", false};
-    if (tags.contains(serverTimeTag)) {
-        QDateTime serverTime = QDateTime::fromString(tags[serverTimeTag], "yyyy-MM-ddThh:mm:ss.zzzZ");
+    if (tags.contains(IrcTags::SERVER_TIME)) {
+        QDateTime serverTime = QDateTime::fromString(tags[IrcTags::SERVER_TIME], "yyyy-MM-ddThh:mm:ss.zzzZ");
         serverTime.setTimeSpec(Qt::UTC);
         if (serverTime.isValid()) {
             e->setTimestamp(serverTime);
         } else {
-            qDebug() << "Invalid timestamp from server-time tag:" << tags[serverTimeTag];
+            qDebug() << "Invalid timestamp from server-time tag:" << tags[IrcTags::SERVER_TIME];
         }
     }