common: Don't warn when "closing" InternalPeer

InternalPeer may be closed legitimately like any other peer type.
Although for InternalPeer this just sets a flag, it should not
produce a warning claiming that the method is not implemented.

Also actually report the open status for InternalPeer. Ensure that
it is constructed in open state, otherwise a signalproxy cannot
be set.

diff --git a/src/common/internalpeer.cpp b/src/common/internalpeer.cpp
index 30b4669..6ce19bd 100644 (file)
--- a/src/common/internalpeer.cpp
+++ b/src/common/internalpeer.cpp
@@ -67,7 +67,7 @@ quint16 InternalPeer::port() const
 
 bool InternalPeer::isOpen() const
 {
-    return true;
+    return _isOpen;
 }
 
 
@@ -85,9 +85,8 @@ bool InternalPeer::isLocal() const
 
 void InternalPeer::close(const QString &reason)
 {
-    // FIXME
-    Q_UNUSED(reason)
-    qWarning() << "closing not implemented!";
+    Q_UNUSED(reason);
+    _isOpen = false;
 }
 
 
@@ -116,6 +115,7 @@ void InternalPeer::setSignalProxy(::SignalProxy *proxy)
 
     if (proxy && !_proxy) {
         _proxy = proxy;
+        _isOpen = true;
         return;
     }
 

diff --git a/src/common/internalpeer.h b/src/common/internalpeer.h
index f40f8eb..a94802d 100644 (file)
--- a/src/common/internalpeer.h
+++ b/src/common/internalpeer.h
@@ -93,7 +93,7 @@ private:
 
 private:
     SignalProxy *_proxy{nullptr};
-    bool _isOpen{false};
+    bool _isOpen{true};
 };
 
 Q_DECLARE_METATYPE(QPointer<InternalPeer>)