Preliminary reports from the field are in, and apparently the
fallback theme handling is too fragile to unleash it onto
unsuspecting users, due to bugs in Qt, desktop environments and
just plain stupid desktop themes.
Override by default to get a consistent look of Quassel in most
cases. Users can still actively choose the other way.
- if (_systemIconTheme.isEmpty() || _systemIconTheme == fallbackTheme || s.value("Icons/OverrideSystemTheme", false).toBool()) {
+ if (_systemIconTheme.isEmpty() || _systemIconTheme == fallbackTheme || s.value("Icons/OverrideSystemTheme", true).toBool()) {
// We have a valid fallback theme and want to override the system theme (if it's even defined), so we're basically done
QIcon::setThemeName(fallbackTheme);
emit iconThemeRefreshed();
// We have a valid fallback theme and want to override the system theme (if it's even defined), so we're basically done
QIcon::setThemeName(fallbackTheme);
emit iconThemeRefreshed();
<string>Override system theme</string>
</property>
<property name="checked">
<string>Override system theme</string>
</property>
<property name="checked">
</property>
<property name="settingsKey" stdset="0">
<string notr="true">/UiStyle/Icons/OverrideSystemTheme</string>
</property>
<property name="defaultValue" stdset="0">
</property>
<property name="settingsKey" stdset="0">
<string notr="true">/UiStyle/Icons/OverrideSystemTheme</string>
</property>
<property name="defaultValue" stdset="0">
</property>
</widget>
</item>
</property>
</widget>
</item>