From e26b9751011574322755e29f218c43b9635d8058 Mon Sep 17 00:00:00 2001 From: Shane Synan Date: Thu, 14 Jun 2018 00:33:41 -0500 Subject: [PATCH 1/1] client: ChatViewSettings check before reload Qss Check if Qt stylesheet needs regenerating before regenerating and reloading the stylesheet, only doing it if the font settings change. Everything else doesn't modify the stylesheet, speeding up changing those settings when font is not changed. --- src/qtui/settingspages/chatviewsettingspage.cpp | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/src/qtui/settingspages/chatviewsettingspage.cpp b/src/qtui/settingspages/chatviewsettingspage.cpp index c3fd8ae5..f1a074f7 100644 --- a/src/qtui/settingspages/chatviewsettingspage.cpp +++ b/src/qtui/settingspages/chatviewsettingspage.cpp @@ -76,9 +76,15 @@ void ChatViewSettingsPage::initSenderPrefixComboBox() void ChatViewSettingsPage::save() { + bool needsStyleReload = SettingsPage::hasChanged(ui.customChatViewFont) + || SettingsPage::hasChanged(ui.chatViewFont); + // Save the general settings SettingsPage::save(); - // Update the stylesheet in case fonts are changed - QtUi::style()->generateSettingsQss(); - QtUi::style()->reload(); + + // Update the stylesheet if fonts are changed + if (needsStyleReload) { + QtUi::style()->generateSettingsQss(); + QtUi::style()->reload(); + } } -- 2.20.1