From d450c85dadf1f813e3274e7c33440a320d876c18 Mon Sep 17 00:00:00 2001
From: Marcus Eggenberger <egs@quassel-irc.org>
Date: Thu, 10 Jul 2008 17:00:58 +0200
Subject: [PATCH 1/1] fixing multiple adds of the same entry to the input
 history (thanks seezer for pointing out)

---
 src/uisupport/inputline.cpp | 65 +++++++++++++++++++++++++++++--------
 src/uisupport/inputline.h   |  2 ++
 2 files changed, 53 insertions(+), 14 deletions(-)

diff --git a/src/uisupport/inputline.cpp b/src/uisupport/inputline.cpp
index 6ea156aa..521613fa 100644
--- a/src/uisupport/inputline.cpp
+++ b/src/uisupport/inputline.cpp
@@ -35,30 +35,67 @@ InputLine::~InputLine() {
 }
 
 void InputLine::keyPressEvent(QKeyEvent * event) {
-  if(event->key() == Qt::Key_Up) {
-    if(idx > 0) { idx--; setText(history[idx]); }
+  switch(event->key()) {
+  case Qt::Key_Up:
     event->accept();
-  } else if(event->key() == Qt::Key_Down) {
-    if(idx < history.count()) idx++;
-    if(idx < history.count()) setText(history[idx]);
-    else if(!text().isEmpty()) {
-      history << text();
-      idx = history.count();
-      setText("");
+
+    if(addToHistory(text())) {
+      clear();
+      break;
+    }
+    
+    if(idx > 0) {
+      idx--;
+      setText(history[idx]);
     }
+
+    break;
+    
+  case Qt::Key_Down:
     event->accept();
-  } else if(event->key() == Qt::Key_Select) {  // for Qtopia
+
+    if(addToHistory(text())) {
+      clear();
+      break;
+    }
+    
+    if(idx < history.count())
+      idx++;
+
+    if(idx < history.count())
+      setText(history[idx]);
+    else
+      clear();
+
+    break;
+    
+  case Qt::Key_Select:		// for Qtopia
     emit returnPressed();
-    QLineEdit::keyPressEvent(event);
-  } else {
+
+  default:
     QLineEdit::keyPressEvent(event);
   }
+}
 
+bool InputLine::addToHistory(const QString &text) {
+  if(text.isEmpty())
+    return false;
+
+  Q_ASSERT(0 <= idx && idx <= history.count());
+  
+  if(history.isEmpty() || text != history[idx - (int)(idx == history.count())]) {
+    // if we change an entry of the history the changed entry is appended to the list and we seek to the end
+    // we could also easily change the entry in the history... per setting maybe?
+    history << text;
+    idx = history.count();
+    return true;
+  } else {
+    return false;
+  }
 }
 
 void InputLine::on_returnPressed() {
-  history << text();
-  idx = history.count();
+  addToHistory(text());
   emit sendText(text());
   clear();
 }
diff --git a/src/uisupport/inputline.h b/src/uisupport/inputline.h
index de4206d9..453f2866 100644
--- a/src/uisupport/inputline.h
+++ b/src/uisupport/inputline.h
@@ -40,6 +40,8 @@ private slots:
   void on_returnPressed();
   void on_textChanged(QString newText);
 
+  bool addToHistory(const QString &text);
+
 signals:
   void sendText(QString text);
 
-- 
2.20.1