From cefad53d40b08c4271a2150533b747c3ca64b735 Mon Sep 17 00:00:00 2001 From: Shane Synan Date: Mon, 16 Jul 2018 16:47:29 -0500 Subject: [PATCH] client: Fix lost unsaved highlights on Import Save highlights before importing if changes exist to avoid losing any unsaved rules when loading the highlight rule list from the client. Test case: 1. Have at least 1 local highlight rule 2. Add remote highlight rule, don't save 3. Import local highlights 4. Unsaved highlight rule gets deleted --- src/qtui/settingspages/corehighlightsettingspage.cpp | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/qtui/settingspages/corehighlightsettingspage.cpp b/src/qtui/settingspages/corehighlightsettingspage.cpp index cafe98f7..9d2f155b 100644 --- a/src/qtui/settingspages/corehighlightsettingspage.cpp +++ b/src/qtui/settingspages/corehighlightsettingspage.cpp @@ -738,6 +738,11 @@ void CoreHighlightSettingsPage::importRules() return; } + if (hasChanged()) { + // Save existing changes first to avoid overwriting them + save(); + } + auto clonedManager = HighlightRuleManager(); clonedManager.fromVariantMap(Client::highlightRuleManager()->toVariantMap()); -- 2.20.1