From c4e71b711a440c5b24dcae785473e3a88ff77015 Mon Sep 17 00:00:00 2001 From: romibi Date: Fri, 1 Sep 2017 10:06:10 +0200 Subject: [PATCH] Fix OSX compile and deploy Set additional compile flag Fix DMG creation (sometimes fails if no volume size is provided) Closes GH-304. (cherry picked from commit 8a7444f4ed825b65acc874d9c2e8359f82523ac0) Conflicts: .travis.yml cmake/FindLdap.cmake --- .travis.yml | 15 +++++++-------- cmake/QuasselCompileSettings.cmake | 3 +-- scripts/build/macosx_makePackage.sh | 3 ++- 3 files changed, 10 insertions(+), 11 deletions(-) diff --git a/.travis.yml b/.travis.yml index bc92eacc..5f48a062 100644 --- a/.travis.yml +++ b/.travis.yml @@ -1,6 +1,5 @@ os: - linux - - osx sudo: required dist: trusty @@ -17,13 +16,13 @@ env: - QT_VERSION=qt5 matrix: + include: + - os: osx + compiler: gcc + env: QT_VERSION=qt5 exclude: - compiler: clang env: QT_VERSION=qt4 - - os: osx - compiler: clang - - os: osx - env: QT_VERSION=qt4 install: |- if [ "$TRAVIS_OS_NAME" == "linux" ] @@ -50,12 +49,12 @@ script: |- make elif [ "$TRAVIS_OS_NAME" == "osx" ] then + PATH=$PATH:/usr/local/opt/qt5/bin if [[ "$TRAVIS_TAG" != "" && "$GH_TOKEN" != "" ]] then - PATH=$PATH:/usr/local/opt/qt5/bin - cmake -G"Ninja" .. -DCMAKE_BUILD_TYPE=Release -DUSE_QT5=ON -DWANT_CORE=ON -DWANT_QTCLIENT=ON -DWANT_MONO=ON -DDEPLOY=ON -DCMAKE_PREFIX_PATH=/usr/local/opt/qt5 + cmake -G"Ninja" .. -DCMAKE_BUILD_TYPE=Release -DUSE_QT5=ON -DWANT_CORE=ON -DWANT_QTCLIENT=ON -DWANT_MONO=ON -DDEPLOY=ON else - cmake -G"Ninja" .. -DCMAKE_BUILD_TYPE=Release -DUSE_QT5=ON -DWANT_CORE=ON -DWANT_QTCLIENT=ON -DWANT_MONO=ON -DCMAKE_PREFIX_PATH=/usr/local/opt/qt5 + cmake -G"Ninja" .. -DCMAKE_BUILD_TYPE=Release -DUSE_QT5=ON -DWANT_CORE=ON -DWANT_QTCLIENT=ON -DWANT_MONO=ON fi ninja install fi diff --git a/cmake/QuasselCompileSettings.cmake b/cmake/QuasselCompileSettings.cmake index f46c515c..9f3e00a7 100644 --- a/cmake/QuasselCompileSettings.cmake +++ b/cmake/QuasselCompileSettings.cmake @@ -80,6 +80,5 @@ endif() # Mac build stuff if (APPLE AND DEPLOY) set(CMAKE_OSX_ARCHITECTURES "x86_64") - set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -mmacosx-version-min=10.9") - set(CMAKE_OSX_SYSROOT "/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.9.sdk") + set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -mmacosx-version-min=10.9 -stdlib=libc++") endif() diff --git a/scripts/build/macosx_makePackage.sh b/scripts/build/macosx_makePackage.sh index 05a1cd2a..4f41171b 100755 --- a/scripts/build/macosx_makePackage.sh +++ b/scripts/build/macosx_makePackage.sh @@ -80,5 +80,6 @@ case $BUILDTYPE in exit 1 ;; esac -hdiutil create -srcfolder ${PACKAGETMPDIR} -format UDBZ -volname "Quassel ${BUILDTYPE} - ${QUASSEL_VERSION}" "${WORKINGDIR}${QUASSEL_DMG}" >/dev/null +PACKAGESIZE=$(echo "$(du -ms ${PACKAGETMPDIR} | cut -f1) * 1.1" | bc) +hdiutil create -srcfolder ${PACKAGETMPDIR} -format UDBZ -size ${PACKAGESIZE}M -volname "Quassel ${BUILDTYPE} - ${QUASSEL_VERSION}" "${WORKINGDIR}${QUASSEL_DMG}" >/dev/null rm -rf ${PACKAGETMPDIR} -- 2.20.1