From bc244c7e95fbfd44ffc6dea8927583478030a588 Mon Sep 17 00:00:00 2001 From: Shane Synan Date: Thu, 31 May 2018 19:20:00 -0500 Subject: [PATCH] client: Clarify QKeySequence::Quit matter in docs QKeySequence::Quit does not set "Ctrl-Q" on Windows, while many Windows programs use that to provide Quit, including Quassel IRC. Modify the comment to explain the situation. See https://doc.qt.io/qt-5/qkeysequence.html --- src/qtui/mainwin.cpp | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/qtui/mainwin.cpp b/src/qtui/mainwin.cpp index 14644fb7..8eefba18 100644 --- a/src/qtui/mainwin.cpp +++ b/src/qtui/mainwin.cpp @@ -402,7 +402,11 @@ void MainWin::setupActions() this, SLOT(showCoreInfoDlg()))); coll->addAction("ConfigureNetworks", new Action(QIcon::fromTheme("configure"), tr("Configure &Networks..."), coll, this, SLOT(on_actionConfigureNetworks_triggered()))); - // FIXME: use QKeySequence::Quit once we depend on Qt 4.6 + // QKeySequence::Quit was added in Qt 4.6, and could be used instead. However, that key + // sequence is empty by default on Windows, which would remove Ctrl-Q to quit. It may be best + // to just keep it this way. + // + // See https://doc.qt.io/qt-5/qkeysequence.html coll->addAction("Quit", new Action(QIcon::fromTheme("application-exit"), tr("&Quit"), coll, this, SLOT(quit()), Qt::CTRL + Qt::Key_Q)); -- 2.20.1