From a5ee609b02cb8d7ebb43b0034a6d50838c426f0b Mon Sep 17 00:00:00 2001 From: "Jan Alexander Steffens (heftig)" Date: Sat, 19 May 2018 12:29:43 +0200 Subject: [PATCH] identd: Simplify responseAvailable via early return --- src/core/identserver.cpp | 23 +++++++++-------------- 1 file changed, 9 insertions(+), 14 deletions(-) diff --git a/src/core/identserver.cpp b/src/core/identserver.cpp index cb72a256..6d23a6ca 100644 --- a/src/core/identserver.cpp +++ b/src/core/identserver.cpp @@ -128,23 +128,18 @@ void IdentServer::respond() { } bool IdentServer::responseAvailable(Request request) { - QString user; - bool success = true; - if (_connections.contains(request.localPort)) { - user = _connections[request.localPort]; - } else { - success = false; + if (!_connections.contains(request.localPort)) { + return false; } - QString data; - if (success) { - data += request.query + " : USERID : Quassel : " + user + "\r\n"; + QString user = _connections[request.localPort]; + QString data = request.query + " : USERID : Quassel : " + user + "\r\n"; - request.socket->write(data.toUtf8()); - request.socket->flush(); - request.socket->close(); - } - return success; + request.socket->write(data.toUtf8()); + request.socket->flush(); + request.socket->close(); + + return true; } void IdentServer::responseUnavailable(Request request) { -- 2.20.1