From 5e28ac5da6da023f0c9813fa77477561f687c96d Mon Sep 17 00:00:00 2001
From: Marcus Eggenberger <egs@quassel-irc.org>
Date: Thu, 11 Mar 2010 17:31:39 +0100
Subject: [PATCH] Messages with redirection flag set (all messages that allow
 client side redirection) will no longer trigger a buffer creation

---
 src/core/coresession.cpp | 31 +++++++++++++++++++++++++++++--
 1 file changed, 29 insertions(+), 2 deletions(-)

diff --git a/src/core/coresession.cpp b/src/core/coresession.cpp
index b7ac9df3..e327f63a 100644
--- a/src/core/coresession.cpp
+++ b/src/core/coresession.cpp
@@ -255,26 +255,53 @@ void CoreSession::customEvent(QEvent *event) {
 void CoreSession::processMessages() {
   if(_messageQueue.count() == 1) {
     const RawMessage &rawMsg = _messageQueue.first();
-    BufferInfo bufferInfo = Core::bufferInfo(user(), rawMsg.networkId, rawMsg.bufferType, rawMsg.target);
+    bool createBuffer = !(rawMsg.flags & Message::Redirected);
+    BufferInfo bufferInfo = Core::bufferInfo(user(), rawMsg.networkId, rawMsg.bufferType, rawMsg.target, createBuffer);
+    if(!bufferInfo.isValid()) {
+      Q_ASSERT(!createBuffer);
+      bufferInfo = Core::bufferInfo(user(), rawMsg.networkId, BufferInfo::StatusBuffer, "");
+    }
     Message msg(bufferInfo, rawMsg.type, rawMsg.text, rawMsg.sender, rawMsg.flags);
     Core::storeMessage(msg);
     emit displayMsg(msg);
   } else {
     QHash<NetworkId, QHash<QString, BufferInfo> > bufferInfoCache;
     MessageList messages;
+    QList<RawMessage> redirectedMessages; // list of Messages which don't enforce a buffer creation
     BufferInfo bufferInfo;
     for(int i = 0; i < _messageQueue.count(); i++) {
       const RawMessage &rawMsg = _messageQueue.at(i);
       if(bufferInfoCache.contains(rawMsg.networkId) && bufferInfoCache[rawMsg.networkId].contains(rawMsg.target)) {
         bufferInfo = bufferInfoCache[rawMsg.networkId][rawMsg.target];
       } else {
-        bufferInfo = Core::bufferInfo(user(), rawMsg.networkId, rawMsg.bufferType, rawMsg.target);
+        bool createBuffer = !(rawMsg.flags & Message::Redirected);
+        bufferInfo = Core::bufferInfo(user(), rawMsg.networkId, rawMsg.bufferType, rawMsg.target, createBuffer);
+        if(!bufferInfo.isValid()) {
+          Q_ASSERT(!createBuffer);
+          redirectedMessages << rawMsg;
+          continue;
+        }
         bufferInfoCache[rawMsg.networkId][rawMsg.target] = bufferInfo;
       }
+      Message msg(bufferInfo, rawMsg.type, rawMsg.text, rawMsg.sender, rawMsg.flags);
+      messages << msg;
+    }
 
+    // recheck if there exists a buffer to store a redirected message in
+    for(int i = 0; i < redirectedMessages.count(); i++) {
+      const RawMessage &rawMsg = _messageQueue.at(i);
+      if(bufferInfoCache.contains(rawMsg.networkId) && bufferInfoCache[rawMsg.networkId].contains(rawMsg.target)) {
+        bufferInfo = bufferInfoCache[rawMsg.networkId][rawMsg.target];
+      } else {
+        // no luck -> we store them in the StatusBuffer
+        bufferInfo = Core::bufferInfo(user(), rawMsg.networkId, BufferInfo::StatusBuffer, "");
+        // add the StatusBuffer to the Cache in case there are more Messages for the original target
+        bufferInfoCache[rawMsg.networkId][rawMsg.target] = bufferInfo;
+      }
       Message msg(bufferInfo, rawMsg.type, rawMsg.text, rawMsg.sender, rawMsg.flags);
       messages << msg;
     }
+
     Core::storeMessages(messages);
     // FIXME: extend protocol to a displayMessages(MessageList)
     for(int i = 0; i < messages.count(); i++) {
-- 
2.20.1