From 5dafdaccc84bc3fa0a9fafa7c594e08a58aa02d4 Mon Sep 17 00:00:00 2001 From: Joshua T Corbin Date: Thu, 8 Jan 2009 18:52:58 -0500 Subject: [PATCH 1/1] Precise error messages in SslServer::setCertificate. --- src/core/sslserver.cpp | 19 +++++++++++++------ 1 file changed, 13 insertions(+), 6 deletions(-) diff --git a/src/core/sslserver.cpp b/src/core/sslserver.cpp index 8006ebdb..2557f2ff 100644 --- a/src/core/sslserver.cpp +++ b/src/core/sslserver.cpp @@ -88,13 +88,20 @@ bool SslServer::setCertificate(const QString &path) { _key = QSslKey(&certFile, QSsl::Rsa); certFile.close(); - if(_cert.isNull() || !_cert.isValid() || _key.isNull()) { - qWarning() << "SslServer: SSL Certificate is either missing or has a wrong format!\n" - << " Quassel Core will still work, but cannot provide SSL for client connections.\n" - << " Please see http://quassel-irc.org/faq/cert to learn how to enable SSL support."; - } else { - _certIsValid = true; + if (_cert.isNull()) { + qWarning() << "SslServer:" << qPrintable(path) << "contains no certificate data"; + return false; + } + if (! _cert.isValid()) { + qWarning() << "SslServer: Invalid certificate"; + return false; } + if (_key.isNull()) { + qWarning() << "SslServer:" << qPrintable(path) << "contains no key data"; + return false; + } + + _certIsValid = true; return _certIsValid; } -- 2.20.1