From 595315d3e061e1e4eadefeaf746cf2e5f2e9ab34 Mon Sep 17 00:00:00 2001 From: Marcus Eggenberger Date: Tue, 8 Jul 2008 20:51:45 +0200 Subject: [PATCH] fixing tabcompleter crash in non channel buffers... ooooops --- src/uisupport/tabcompleter.cpp | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/uisupport/tabcompleter.cpp b/src/uisupport/tabcompleter.cpp index 4ac8260a..03d49ecd 100644 --- a/src/uisupport/tabcompleter.cpp +++ b/src/uisupport/tabcompleter.cpp @@ -40,13 +40,14 @@ TabCompleter::TabCompleter(InputLine *inputLine_) } void TabCompleter::buildCompletionList() { + // ensure a safe state in case we return early. completionMap.clear(); + nextCompletion = completionMap.begin(); + // this is the first time tab is pressed -> build up the completion list and it's iterator QModelIndex currentIndex = Client::bufferModel()->currentIndex(); - if(!currentIndex.data(NetworkModel::BufferIdRole).isValid()) { - nextCompletion = completionMap.begin(); + if(!currentIndex.data(NetworkModel::BufferIdRole).isValid()) return; - } NetworkId networkId = currentIndex.data(NetworkModel::NetworkIdRole).value(); QString channelName = currentIndex.sibling(currentIndex.row(), 0).data().toString(); -- 2.20.1