From 518cd2bc478ab3675a60ec46d3ef183cace0cae7 Mon Sep 17 00:00:00 2001
From: Shane Synan <digitalcircuit36939@gmail.com>
Date: Wed, 22 Jul 2020 18:46:16 -0400
Subject: [PATCH] qtui: Add keyboard/mouse access to version links

Enable the use of mouse and keyboard for accessing Quassel version
information links, including mouse selection (for copy-paste).

This fixes having to right-click -> Copy Link Location to open commit
information.  Note that untrusted clients/cores can set their version
information to open ANY external link, including disguised/phishing
links.  However, this requires manual interaction and I suspect
there's bigger problems if one is connecting to untrusted Quassel
clients/cores and clicking the links in File -> Core Info...

Update About to also allow keyboard access to the version link.  All
the other links were keyboard accessible already.
---
 src/qtui/aboutdlg.ui          | 2 +-
 src/qtui/coreinfodlg.ui       | 6 ++++++
 src/qtui/coresessionwidget.ui | 6 ++++++
 3 files changed, 13 insertions(+), 1 deletion(-)

diff --git a/src/qtui/aboutdlg.ui b/src/qtui/aboutdlg.ui
index e7edcd99..b98f7245 100644
--- a/src/qtui/aboutdlg.ui
+++ b/src/qtui/aboutdlg.ui
@@ -78,7 +78,7 @@ p, li { white-space: pre-wrap; }
              <bool>true</bool>
             </property>
             <property name="textInteractionFlags">
-             <set>Qt::LinksAccessibleByMouse|Qt::TextSelectableByMouse</set>
+             <set>Qt::TextBrowserInteraction</set>
             </property>
            </widget>
           </item>
diff --git a/src/qtui/coreinfodlg.ui b/src/qtui/coreinfodlg.ui
index 880c9558..b71ee795 100644
--- a/src/qtui/coreinfodlg.ui
+++ b/src/qtui/coreinfodlg.ui
@@ -28,6 +28,12 @@
        <property name="text">
         <string notr="true">&lt;core version&gt;</string>
        </property>
+       <property name="openExternalLinks">
+        <bool>true</bool>
+       </property>
+       <property name="textInteractionFlags">
+        <set>Qt::TextBrowserInteraction</set>
+       </property>
       </widget>
      </item>
      <item row="1" column="0">
diff --git a/src/qtui/coresessionwidget.ui b/src/qtui/coresessionwidget.ui
index a0e6531d..07e5c220 100644
--- a/src/qtui/coresessionwidget.ui
+++ b/src/qtui/coresessionwidget.ui
@@ -43,6 +43,12 @@
           <property name="text">
            <string notr="true">v0.13-pre (0.12.0+372 git-12df418)</string>
           </property>
+          <property name="openExternalLinks">
+           <bool>true</bool>
+          </property>
+          <property name="textInteractionFlags">
+           <set>Qt::TextBrowserInteraction</set>
+          </property>
          </widget>
         </item>
         <item row="1" column="0">
-- 
2.20.1