From 3914857f784637e678a8ea029b338228ff67d94e Mon Sep 17 00:00:00 2001 From: Marcus Eggenberger Date: Fri, 7 Dec 2007 15:28:57 +0000 Subject: [PATCH] Fixed possible segfault in IrcChannel::isKnownUser() --- src/common/ircchannel.cpp | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/src/common/ircchannel.cpp b/src/common/ircchannel.cpp index 2bcb8ca0..47082dd6 100644 --- a/src/common/ircchannel.cpp +++ b/src/common/ircchannel.cpp @@ -49,19 +49,17 @@ IrcChannel::~IrcChannel() { // PUBLIC: // ==================== bool IrcChannel::isKnownUser(IrcUser *ircuser) const { - bool isknown = true; - if(ircuser == 0) { qWarning() << "Channel" << name() << "received IrcUser Nullpointer!"; - isknown = false; + return false; } if(!_userModes.contains(ircuser)) { qWarning() << "Channel" << name() << "received data for unknown User" << ircuser->nick(); - isknown = false; + return false; } - - return isknown; + + return true; } bool IrcChannel::isValidChannelUserMode(const QString &mode) const { -- 2.20.1