From 2e8eab59dd72e37a740d16d9484502d077aef64d Mon Sep 17 00:00:00 2001 From: Shane Synan Date: Fri, 18 Aug 2017 15:34:38 -0500 Subject: [PATCH] core: Stop ratelimiting log spam with old client Downgrade invalid 'setMessageRateBurstSize' and 'setMessageRateDelay' warning messages to debugging level. This happens any time an older client tries to configure a network for a newer core and in most cases can be ignored. Should an issue arise, the log level can be set to debug. --- src/common/network.cpp | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/common/network.cpp b/src/common/network.cpp index 885cc50b..3b1fe1d8 100644 --- a/src/common/network.cpp +++ b/src/common/network.cpp @@ -731,8 +731,8 @@ void Network::setMessageRateBurstSize(quint32 burstSize) if (burstSize < 1) { // Can't go slower than one message at a time. Also blocks old clients from trying to set // this to 0. - qWarning() << "Received invalid setMessageRateBurstSize data - message burst size must be " - "non-zero positive, given" << burstSize; + qDebug() << "Received invalid setMessageRateBurstSize data - message burst size must be " + "non-zero positive, given" << burstSize; return; } if (_messageRateBurstSize != burstSize) { @@ -749,8 +749,8 @@ void Network::setMessageRateDelay(quint32 messageDelay) if (messageDelay == 0) { // Nonsensical to have no delay - just check the Unlimited box instead. Also blocks old // clients from trying to set this to 0. - qWarning() << "Received invalid setMessageRateDelay data - message delay must be non-zero " - "positive, given" << messageDelay; + qDebug() << "Received invalid setMessageRateDelay data - message delay must be non-zero " + "positive, given" << messageDelay; return; } if (_messageRateDelay != messageDelay) { -- 2.20.1