From 0b277c98276e042f472e96f3eef9297a04f214f8 Mon Sep 17 00:00:00 2001 From: Shane Synan Date: Sat, 11 Jul 2020 17:51:45 -0400 Subject: [PATCH] common: Fix IrcUser::quitInternal not syncing quit Fix the new IrcUser::quitInternal() function to call IrcUser::quit() over the network, restoring compatibility with both old and new Quassel clients. Only the core needs upgraded to fix this; the client does not sync calls to IrcUser::quit(). > Before, core + client latest <-- kiwipre-68 ([...]) has quit (Client Quit) 2020-07-11 17:53:26 [Warn ] "no matching slot for sync call: IrcUser::quitInternal (objectName=\"2/kiwipre-68\"). Params are:" () > After, core + client latest IrcUser is successfully marked as having quit, removed from nick list. Fixes the fix in 7298446b3e86140c4bbbfe7aeeb959c16c53363c --- src/common/ircuser.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/common/ircuser.cpp b/src/common/ircuser.cpp index ec1ecb1c..de299800 100644 --- a/src/common/ircuser.cpp +++ b/src/common/ircuser.cpp @@ -334,7 +334,7 @@ void IrcUser::quitInternal(bool skip_sync) channel->part(this); } network()->removeIrcUser(this); - if (!skip_sync) SYNC(NO_ARG) + if (!skip_sync) SYNC_OTHER(quit, NO_ARG) emit quited(); } -- 2.20.1