From 09ced75541a8702726ed5d66ebc628db2bd50423 Mon Sep 17 00:00:00 2001 From: Manuel Nickschas Date: Mon, 9 Feb 2015 00:55:41 +0100 Subject: [PATCH] Add comment regarding the removal of X11 hacks to GraphicalUi Turns out all window activation stuff just works with Qt5, even with KF5 integration enabled. So there is no need to employ fugly X11 hacks in order to bypass focus stealing prevention, as was required in KDE4. Because GraphicalUi doesn't seem to require any more porting changes, add a comment instead to later remove the hacks together with Qt4/KDE4. --- src/uisupport/graphicalui.cpp | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/uisupport/graphicalui.cpp b/src/uisupport/graphicalui.cpp index 0fb34b04..d1e106d1 100644 --- a/src/uisupport/graphicalui.cpp +++ b/src/uisupport/graphicalui.cpp @@ -146,6 +146,9 @@ bool GraphicalUi::eventFilter(QObject *obj, QEvent *event) } +// NOTE: Window activation stuff seems to work just fine in Plasma 5 without requiring X11 hacks. +// TODO: Evaluate cleaning all this up once we can get rid of Qt4/KDE4 + // Code taken from KStatusNotifierItem for handling minimize/restore bool GraphicalUi::checkMainWidgetVisibility(bool perform) -- 2.20.1