From: Manuel Nickschas <sputnick@quassel-irc.org>
Date: Thu, 30 Sep 2010 07:23:49 +0000 (+0200)
Subject: Change the order of MessageEvent ctor params
X-Git-Tag: 0.8-beta1~109
X-Git-Url: https://git.quassel-irc.org/?p=quassel.git;a=commitdiff_plain;h=f86267b88039f7979cc8fe6dac8c1ec380c236be;hp=f9c4ee168a794add5261a7f1b6abb518f5987f8c;ds=sidebyside

Change the order of MessageEvent ctor params

Be careful, params are specified in an order different from the old displayMsg(),
since it makes more sense like this and optimizes default arg use.
---

diff --git a/src/common/messageevent.cpp b/src/common/messageevent.cpp
index d7f3b7c9..83afcac7 100644
--- a/src/common/messageevent.cpp
+++ b/src/common/messageevent.cpp
@@ -21,12 +21,12 @@
 #include "messageevent.h"
 
 
-MessageEvent::MessageEvent(Message::Type msgType, Network *net, const QString &msg, const QString &target, const QString &sender, Message::Flags flags)
+MessageEvent::MessageEvent(Message::Type msgType, Network *net, const QString &msg, const QString &sender, const QString &target, Message::Flags flags)
     : NetworkEvent(EventManager::MessageEvent, net),
       _msgType(msgType),
       _text(msg),
-      _target(target),
       _sender(sender),
+      _target(target),
       _msgFlags(flags)
 {
   IrcChannel *channel = network()->ircChannel(_target);
diff --git a/src/common/messageevent.h b/src/common/messageevent.h
index 11e9987e..6938db73 100644
--- a/src/common/messageevent.h
+++ b/src/common/messageevent.h
@@ -33,8 +33,8 @@ public:
   explicit MessageEvent(Message::Type msgType,
                         Network *network,
                         const QString &msg,
-                        const QString &target = QString(),
                         const QString &sender = QString(),
+                        const QString &target = QString(),
                         Message::Flags msgFlags = Message::None
                         );
 
@@ -69,7 +69,7 @@ private:
 
   Message::Type _msgType;
   BufferInfo::Type _bufferType;
-  QString _text, _target, _sender;
+  QString _text, _sender, _target;
   Message::Flags _msgFlags;
 };