From: Sebastian Goth <seezer@roath.org>
Date: Wed, 28 Apr 2010 17:16:36 +0000 (+0200)
Subject: Handle /query and /join without args nicely
X-Git-Tag: 0.7-beta1~75
X-Git-Url: https://git.quassel-irc.org/?p=quassel.git;a=commitdiff_plain;h=f47c3bdeacbc163f558751bf090d499fd1a36cb6;hp=1cb98a44044e7756fa58ae67a6065015d776ba0c

Handle /query and /join without args nicely

Adapts MR84 to the refactored ClientUserInputHandler
Thanks johu for the initial fix!

Fixes #831 and renders MR84 obsolete.
---

diff --git a/src/client/clientuserinputhandler.cpp b/src/client/clientuserinputhandler.cpp
index 8abc79dd..3e7ece3c 100644
--- a/src/client/clientuserinputhandler.cpp
+++ b/src/client/clientuserinputhandler.cpp
@@ -29,6 +29,7 @@
 #include "network.h"
 #include "types.h"
 #include "bufferinfo.h"
+#include "messagemodel.h"
 
 #include <QDateTime>
 
@@ -81,12 +82,20 @@ void ClientUserInputHandler::handleExec(const BufferInfo &bufferInfo, const QStr
 }
 
 void ClientUserInputHandler::handleJoin(const BufferInfo &bufferInfo, const QString &text) {
+  if(text.isEmpty()) {
+    Client::messageModel()->insertErrorMessage(bufferInfo, tr("/JOIN expects a channel"));
+    return;
+  }
   switchBuffer(bufferInfo.networkId(), text.section(' ', 0, 0));
   // send to core
   defaultHandler("JOIN", bufferInfo, text);
 }
 
 void ClientUserInputHandler::handleQuery(const BufferInfo &bufferInfo, const QString &text) {
+  if(text.isEmpty()) {
+    Client::messageModel()->insertErrorMessage(bufferInfo, tr("/QUERY expects at least a nick"));
+    return;
+  }
   switchBuffer(bufferInfo.networkId(), text.section(' ', 0, 0));
   // send to core
   defaultHandler("QUERY", bufferInfo, text);
diff --git a/src/client/clientuserinputhandler.h b/src/client/clientuserinputhandler.h
index 0b44c910..e27f26ea 100644
--- a/src/client/clientuserinputhandler.h
+++ b/src/client/clientuserinputhandler.h
@@ -21,7 +21,6 @@
 #ifndef CLIENTUSERINPUTHANDLER_H_
 #define CLIENTUSERINPUTHANDLER_H_
 
-//#include "bufferinfo.h"
 #include "basichandler.h"
 
 class BufferInfo;