From: Manuel Nickschas <sputnick@quassel-irc.org>
Date: Thu, 15 Jan 2009 20:11:59 +0000 (+0100)
Subject: Improve mouse button detection for mouse release events
X-Git-Tag: 0.4.0~214
X-Git-Url: https://git.quassel-irc.org/?p=quassel.git;a=commitdiff_plain;h=e8e50ceb0f0df46a6f281f6d4fd587f00fe532d3;ds=inline

Improve mouse button detection for mouse release events

This might be a solution to the strange behavior when clicking links in Windows
(as described in Bug 483). Please test and feedback.
---

diff --git a/src/qtui/chatitem.cpp b/src/qtui/chatitem.cpp
index fc45b77c..9b7c2203 100644
--- a/src/qtui/chatitem.cpp
+++ b/src/qtui/chatitem.cpp
@@ -278,7 +278,7 @@ void ChatItem::mousePressEvent(QGraphicsSceneMouseEvent *event) {
 }
 
 void ChatItem::mouseReleaseEvent(QGraphicsSceneMouseEvent *event) {
-  if(_selectionMode != NoSelection && !event->buttons() & Qt::LeftButton) {
+  if(_selectionMode != NoSelection && event->button() == Qt::LeftButton) {
     chatScene()->selectionToClipboard(QClipboard::Selection);
     event->accept();
   } else
diff --git a/src/qtui/chatscene.cpp b/src/qtui/chatscene.cpp
index 0dc3ec61..60f3f1bb 100644
--- a/src/qtui/chatscene.cpp
+++ b/src/qtui/chatscene.cpp
@@ -653,7 +653,7 @@ void ChatScene::mouseDoubleClickEvent(QGraphicsSceneMouseEvent *event) {
 }
 
 void ChatScene::mouseReleaseEvent(QGraphicsSceneMouseEvent *event) {
-  if(!event->buttons() & Qt::LeftButton) {
+  if(event->button() == Qt::LeftButton && _leftButtonPressed) {
     _leftButtonPressed = false;
     if(_clickMode != NoClick) {
       if(_clickMode == SingleClick)