From: Shane Synan <digitalcircuit36939@gmail.com>
Date: Thu, 14 Jun 2018 05:33:41 +0000 (-0500)
Subject: client: ChatViewSettings check before reload Qss
X-Git-Tag: travis-deploy-test~14
X-Git-Url: https://git.quassel-irc.org/?p=quassel.git;a=commitdiff_plain;h=e26b9751011574322755e29f218c43b9635d8058;hp=4171bdf884b6bbc7dad85f100a29746bf955191f

client: ChatViewSettings check before reload Qss

Check if Qt stylesheet needs regenerating before regenerating and
reloading the stylesheet, only doing it if the font settings change.
Everything else doesn't modify the stylesheet, speeding up changing
those settings when font is not changed.
---

diff --git a/src/qtui/settingspages/chatviewsettingspage.cpp b/src/qtui/settingspages/chatviewsettingspage.cpp
index c3fd8ae5..f1a074f7 100644
--- a/src/qtui/settingspages/chatviewsettingspage.cpp
+++ b/src/qtui/settingspages/chatviewsettingspage.cpp
@@ -76,9 +76,15 @@ void ChatViewSettingsPage::initSenderPrefixComboBox()
 
 void ChatViewSettingsPage::save()
 {
+    bool needsStyleReload = SettingsPage::hasChanged(ui.customChatViewFont)
+            || SettingsPage::hasChanged(ui.chatViewFont);
+
     // Save the general settings
     SettingsPage::save();
-    // Update the stylesheet in case fonts are changed
-    QtUi::style()->generateSettingsQss();
-    QtUi::style()->reload();
+
+    // Update the stylesheet if fonts are changed
+    if (needsStyleReload) {
+        QtUi::style()->generateSettingsQss();
+        QtUi::style()->reload();
+    }
 }