From: Manuel Nickschas Date: Sun, 9 Sep 2018 20:44:18 +0000 (+0200) Subject: modernize: Use auto where the type is clear from context X-Git-Tag: test-travis-01~139 X-Git-Url: https://git.quassel-irc.org/?p=quassel.git;a=commitdiff_plain;h=e2188dc438be6f3eb0d9cdf47d28821aefe9835e modernize: Use auto where the type is clear from context Apply clang-tidy's modernize-use-auto fix, which uses auto where the type would otherwise be duplicated in the line (e.g. when casting a type, or creating an instance with 'new'). --- diff --git a/src/client/buffermodel.cpp b/src/client/buffermodel.cpp index 3af42445..e5011f2e 100644 --- a/src/client/buffermodel.cpp +++ b/src/client/buffermodel.cpp @@ -70,7 +70,7 @@ void BufferModel::networkConnectionChanged(Network::ConnectionState state) if (currentIndex().isValid()) return; { - Network *net = qobject_cast(sender()); + auto *net = qobject_cast(sender()); Q_ASSERT(net); setCurrentIndex(mapFromSource(Client::networkModel()->networkIndex(net->networkId()))); } diff --git a/src/client/bufferviewoverlay.cpp b/src/client/bufferviewoverlay.cpp index 20d33f85..8e802fd9 100644 --- a/src/client/bufferviewoverlay.cpp +++ b/src/client/bufferviewoverlay.cpp @@ -173,7 +173,7 @@ void BufferViewOverlay::viewInitialized(BufferViewConfig *config) void BufferViewOverlay::viewInitialized() { - BufferViewConfig *config = qobject_cast(sender()); + auto *config = qobject_cast(sender()); Q_ASSERT(config); viewInitialized(config); diff --git a/src/client/client.cpp b/src/client/client.cpp index 3c455aed..f6e8d24d 100644 --- a/src/client/client.cpp +++ b/src/client/client.cpp @@ -222,7 +222,7 @@ void Client::coreNetworkCreated(NetworkId id) qWarning() << "Creation of already existing network requested!"; return; } - Network *net = new Network(id, this); + auto *net = new Network(id, this); addNetwork(net); } @@ -283,7 +283,7 @@ void Client::removeIdentity(IdentityId id) void Client::coreIdentityCreated(const Identity &other) { if (!_identities.contains(other.id())) { - Identity *identity = new Identity(other, this); + auto *identity = new Identity(other, this); _identities[other.id()] = identity; identity->setInitialized(); signalProxy()->synchronize(identity); @@ -557,7 +557,7 @@ void Client::setDisconnectedFromCore() void Client::networkDestroyed() { - Network *net = static_cast(sender()); + auto *net = static_cast(sender()); QHash::iterator netIter = _networks.begin(); while (netIter != _networks.end()) { if (*netIter == net) { diff --git a/src/client/clientauthhandler.cpp b/src/client/clientauthhandler.cpp index a3fc870d..acd670d9 100644 --- a/src/client/clientauthhandler.cpp +++ b/src/client/clientauthhandler.cpp @@ -58,7 +58,7 @@ void ClientAuthHandler::connectToCore() CoreAccountSettings s; #ifdef HAVE_SSL - QSslSocket *socket = new QSslSocket(this); + auto *socket = new QSslSocket(this); // make sure the warning is shown if we happen to connect without SSL support later s.setAccountValue("ShowNoClientSslWarning", true); #else @@ -237,8 +237,8 @@ void ClientAuthHandler::onReadyRead() socket()->read((char *)&reply, 4); reply = qFromBigEndian(reply); - Protocol::Type type = static_cast(reply & 0xff); - quint16 protoFeatures = static_cast(reply>>8 & 0xffff); + auto type = static_cast(reply & 0xff); + auto protoFeatures = static_cast(reply>>8 & 0xffff); _connectionFeatures = static_cast(reply>>24); Compressor::CompressionLevel level; @@ -431,7 +431,7 @@ void ClientAuthHandler::checkAndEnableSsl(bool coreSupportsSsl) // Make sure the warning is shown next time we don't have SSL in the core s.setAccountValue("ShowNoCoreSslWarning", true); - QSslSocket *sslSocket = qobject_cast(socket()); + auto *sslSocket = qobject_cast(socket()); Q_ASSERT(sslSocket); connect(sslSocket, SIGNAL(encrypted()), SLOT(onSslSocketEncrypted())); connect(sslSocket, SIGNAL(sslErrors(QList)), SLOT(onSslErrors())); @@ -463,7 +463,7 @@ void ClientAuthHandler::checkAndEnableSsl(bool coreSupportsSsl) void ClientAuthHandler::onSslSocketEncrypted() { - QSslSocket *socket = qobject_cast(sender()); + auto *socket = qobject_cast(sender()); Q_ASSERT(socket); if (!socket->sslErrors().count()) { @@ -485,7 +485,7 @@ void ClientAuthHandler::onSslSocketEncrypted() void ClientAuthHandler::onSslErrors() { - QSslSocket *socket = qobject_cast(sender()); + auto *socket = qobject_cast(sender()); Q_ASSERT(socket); CoreAccountSettings s; diff --git a/src/client/clienttransfermanager.cpp b/src/client/clienttransfermanager.cpp index 9042b298..5cd4d078 100644 --- a/src/client/clienttransfermanager.cpp +++ b/src/client/clienttransfermanager.cpp @@ -46,7 +46,7 @@ void ClientTransferManager::onCoreTransferAdded(const QUuid &uuid) void ClientTransferManager::onTransferInitDone() { - Transfer *transfer = qobject_cast(sender()); + auto *transfer = qobject_cast(sender()); Q_ASSERT(transfer); addTransfer(transfer); } diff --git a/src/client/clientuserinputhandler.cpp b/src/client/clientuserinputhandler.cpp index 6b466824..573a28ab 100644 --- a/src/client/clientuserinputhandler.cpp +++ b/src/client/clientuserinputhandler.cpp @@ -89,7 +89,7 @@ void ClientUserInputHandler::defaultHandler(const QString &cmd, const BufferInfo void ClientUserInputHandler::handleExec(const BufferInfo &bufferInfo, const QString &execString) { - ExecWrapper *exec = new ExecWrapper(this); // gets suicidal when it's done + auto *exec = new ExecWrapper(this); // gets suicidal when it's done exec->start(bufferInfo, execString); } diff --git a/src/client/coreconnection.cpp b/src/client/coreconnection.cpp index d333b532..c6f4c9f5 100644 --- a/src/client/coreconnection.cpp +++ b/src/client/coreconnection.cpp @@ -133,7 +133,7 @@ void CoreConnection::reconnectTimeout() void CoreConnection::networkDetectionModeChanged(const QVariant &vmode) { CoreConnectionSettings s; - CoreConnectionSettings::NetworkDetectionMode mode = (CoreConnectionSettings::NetworkDetectionMode)vmode.toInt(); + auto mode = (CoreConnectionSettings::NetworkDetectionMode)vmode.toInt(); if (mode == CoreConnectionSettings::UsePingTimeout) Client::signalProxy()->setMaxHeartBeatCount(s.pingTimeoutInterval() / 30); else { @@ -375,7 +375,7 @@ void CoreConnection::connectToCurrentAccount() return; } - InternalPeer *peer = new InternalPeer(); + auto *peer = new InternalPeer(); _peer = peer; Client::instance()->signalProxy()->addPeer(peer); // sigproxy will take ownership emit connectionMsg(tr("Initializing...")); @@ -496,7 +496,7 @@ void CoreConnection::syncToCore(const Protocol::SessionState &sessionState) NetworkId netid = networkid.value(); if (Client::network(netid)) continue; - Network *net = new Network(netid, Client::instance()); + auto *net = new Network(netid, Client::instance()); _netsToSync.insert(net); connect(net, SIGNAL(initDone()), SLOT(networkInitDone())); connect(net, SIGNAL(destroyed()), SLOT(networkInitDone())); diff --git a/src/client/messagefilter.cpp b/src/client/messagefilter.cpp index 578f340e..fd6e78b7 100644 --- a/src/client/messagefilter.cpp +++ b/src/client/messagefilter.cpp @@ -245,7 +245,7 @@ bool MessageFilter::filterAcceptsRow(int sourceRow, const QModelIndex &sourcePar } // Mark query as having a quit message inserted - MessageFilter *that = const_cast(this); + auto *that = const_cast(this); that->_filteredQuitMsgTime.insert(messageTimestamp); return true; } diff --git a/src/client/networkmodel.cpp b/src/client/networkmodel.cpp index 7b7f5bc4..e4e2e790 100644 --- a/src/client/networkmodel.cpp +++ b/src/client/networkmodel.cpp @@ -135,7 +135,7 @@ BufferItem *NetworkItem::bufferItem(const BufferInfo &bufferInfo) switch (bufferInfo.type()) { case BufferInfo::ChannelBuffer: { - ChannelBufferItem *channelBufferItem = static_cast(bufferItem); + auto *channelBufferItem = static_cast(bufferItem); if (_network) { IrcChannel *ircChannel = _network->ircChannel(bufferInfo.bufferName()); if (ircChannel) @@ -263,7 +263,7 @@ QString NetworkItem::toolTip(int column) const void NetworkItem::onBeginRemoveChilds(int start, int end) { for (int i = start; i <= end; i++) { - StatusBufferItem *statusBufferItem = qobject_cast(child(i)); + auto *statusBufferItem = qobject_cast(child(i)); if (statusBufferItem) { _statusBufferItem = nullptr; break; @@ -486,7 +486,7 @@ StatusBufferItem::StatusBufferItem(const BufferInfo &bufferInfo, NetworkItem *pa QString StatusBufferItem::toolTip(int column) const { - NetworkItem *networkItem = qobject_cast(parent()); + auto *networkItem = qobject_cast(parent()); if (networkItem) return networkItem->toolTip(column); else @@ -975,7 +975,7 @@ void ChannelBufferItem::userModeChanged(IrcUser *ircUser) // find the item that needs reparenting IrcUserItem *ircUserItem = nullptr; for (int i = 0; i < childCount(); i++) { - UserCategoryItem *oldCategoryItem = qobject_cast(child(i)); + auto *oldCategoryItem = qobject_cast(child(i)); Q_ASSERT(oldCategoryItem); IrcUserItem *userItem = oldCategoryItem->findIrcUser(ircUser); if (userItem) { @@ -1065,7 +1065,7 @@ void UserCategoryItem::addUsers(const QList &ircUsers) bool UserCategoryItem::removeUser(IrcUser *ircUser) { IrcUserItem *userItem = findIrcUser(ircUser); - bool success = (bool)userItem; + auto success = (bool)userItem; if (success) { removeChild(userItem); emit dataChanged(0); @@ -1271,11 +1271,11 @@ QString IrcUserItem::channelModes() const { // IrcUserItems are parented to UserCategoryItem, which are parented to ChannelBufferItem. // We want the channel buffer item in order to get the channel-specific user modes. - UserCategoryItem *category = qobject_cast(parent()); + auto *category = qobject_cast(parent()); if (!category) return QString(); - ChannelBufferItem *channel = qobject_cast(category->parent()); + auto *channel = qobject_cast(category->parent()); if (!channel) return QString(); @@ -1439,7 +1439,7 @@ QList > NetworkModel::mimeDataToBufferList(const QMim QMimeData *NetworkModel::mimeData(const QModelIndexList &indexes) const { - QMimeData *mimeData = new QMimeData(); + auto *mimeData = new QMimeData(); QStringList bufferlist; QString netid, uid, bufferid; @@ -1690,7 +1690,7 @@ NetworkId NetworkModel::networkId(BufferId bufferId) const if (!_bufferItemCache.contains(bufferId)) return NetworkId(); - NetworkItem *netItem = qobject_cast(_bufferItemCache[bufferId]->parent()); + auto *netItem = qobject_cast(_bufferItemCache[bufferId]->parent()); if (netItem) return netItem->networkId(); else @@ -1703,7 +1703,7 @@ QString NetworkModel::networkName(BufferId bufferId) const if (!_bufferItemCache.contains(bufferId)) return QString(); - NetworkItem *netItem = qobject_cast(_bufferItemCache[bufferId]->parent()); + auto *netItem = qobject_cast(_bufferItemCache[bufferId]->parent()); if (netItem) return netItem->networkName(); else @@ -1718,7 +1718,7 @@ BufferId NetworkModel::bufferId(NetworkId networkId, const QString &bufferName, return BufferId(); for (int i = 0; i < netItem->childCount(); i++) { - BufferItem *bufferItem = qobject_cast(netItem->child(i)); + auto *bufferItem = qobject_cast(netItem->child(i)); if (bufferItem && !bufferItem->bufferName().compare(bufferName, cs)) return bufferItem->bufferId(); } diff --git a/src/client/selectionmodelsynchronizer.cpp b/src/client/selectionmodelsynchronizer.cpp index 717ef4e0..d5b8f8bc 100644 --- a/src/client/selectionmodelsynchronizer.cpp +++ b/src/client/selectionmodelsynchronizer.cpp @@ -87,7 +87,7 @@ void SelectionModelSynchronizer::removeSelectionModel(QItemSelectionModel *model void SelectionModelSynchronizer::selectionModelDestroyed(QObject *object) { - QItemSelectionModel *model = static_cast(object); + auto *model = static_cast(object); QSet::iterator iter = _selectionModels.begin(); while (iter != _selectionModels.end()) { if (*iter == model) { @@ -107,7 +107,7 @@ void SelectionModelSynchronizer::syncedCurrentChanged(const QModelIndex ¤t if (!_changeCurrentEnabled) return; - QItemSelectionModel *selectionModel = qobject_cast(sender()); + auto *selectionModel = qobject_cast(sender()); Q_ASSERT(selectionModel); QModelIndex newSourceCurrent = mapToSource(current, selectionModel); if (newSourceCurrent.isValid() && newSourceCurrent != currentIndex()) @@ -123,7 +123,7 @@ void SelectionModelSynchronizer::syncedSelectionChanged(const QItemSelection &se if (!_changeSelectionEnabled) return; - QItemSelectionModel *selectionModel = qobject_cast(sender()); + auto *selectionModel = qobject_cast(sender()); Q_ASSERT(selectionModel); QItemSelection mappedSelection = selectionModel->selection(); diff --git a/src/client/treemodel.cpp b/src/client/treemodel.cpp index 768a2959..486ed6c9 100644 --- a/src/client/treemodel.cpp +++ b/src/client/treemodel.cpp @@ -136,7 +136,7 @@ void AbstractTreeItem::customEvent(QEvent *event) event->accept(); - RemoveChildLaterEvent *removeEvent = static_cast(event); + auto *removeEvent = static_cast(event); int childRow = _childItems.indexOf(removeEvent->child()); if (childRow == -1) return; @@ -392,7 +392,7 @@ QModelIndex TreeModel::parent(const QModelIndex &index) const return QModelIndex(); } - AbstractTreeItem *childItem = static_cast(index.internalPointer()); + auto *childItem = static_cast(index.internalPointer()); AbstractTreeItem *parentItem = childItem->parent(); Q_ASSERT(parentItem); @@ -438,7 +438,7 @@ QVariant TreeModel::data(const QModelIndex &index, int role) const if (!index.isValid()) return QVariant(); - AbstractTreeItem *item = static_cast(index.internalPointer()); + auto *item = static_cast(index.internalPointer()); return item->data(index.column(), role); } @@ -448,7 +448,7 @@ bool TreeModel::setData(const QModelIndex &index, const QVariant &value, int rol if (!index.isValid()) return false; - AbstractTreeItem *item = static_cast(index.internalPointer()); + auto *item = static_cast(index.internalPointer()); return item->setData(index.column(), value, role); } @@ -459,7 +459,7 @@ Qt::ItemFlags TreeModel::flags(const QModelIndex &index) const return rootItem->flags() & Qt::ItemIsDropEnabled; } else { - AbstractTreeItem *item = static_cast(index.internalPointer()); + auto *item = static_cast(index.internalPointer()); return item->flags(); } } @@ -476,7 +476,7 @@ QVariant TreeModel::headerData(int section, Qt::Orientation orientation, int rol void TreeModel::itemDataChanged(int column) { - AbstractTreeItem *item = qobject_cast(sender()); + auto *item = qobject_cast(sender()); QModelIndex leftIndex, rightIndex; if (item == rootItem) @@ -514,7 +514,7 @@ void TreeModel::connectItem(AbstractTreeItem *item) void TreeModel::beginAppendChilds(int firstRow, int lastRow) { - AbstractTreeItem *parentItem = qobject_cast(sender()); + auto *parentItem = qobject_cast(sender()); if (!parentItem) { qWarning() << "TreeModel::beginAppendChilds(): cannot append Children to unknown parent"; return; @@ -531,7 +531,7 @@ void TreeModel::beginAppendChilds(int firstRow, int lastRow) void TreeModel::endAppendChilds() { - AbstractTreeItem *parentItem = qobject_cast(sender()); + auto *parentItem = qobject_cast(sender()); if (!parentItem) { qWarning() << "TreeModel::endAppendChilds(): cannot append Children to unknown parent"; return; @@ -553,7 +553,7 @@ void TreeModel::endAppendChilds() void TreeModel::beginRemoveChilds(int firstRow, int lastRow) { - AbstractTreeItem *parentItem = qobject_cast(sender()); + auto *parentItem = qobject_cast(sender()); if (!parentItem) { qWarning() << "TreeModel::beginRemoveChilds(): cannot append Children to unknown parent"; return; @@ -577,7 +577,7 @@ void TreeModel::beginRemoveChilds(int firstRow, int lastRow) void TreeModel::endRemoveChilds() { - AbstractTreeItem *parentItem = qobject_cast(sender()); + auto *parentItem = qobject_cast(sender()); if (!parentItem) { qWarning() << "TreeModel::endRemoveChilds(): cannot remove Children from unknown parent"; return; diff --git a/src/common/event.cpp b/src/common/event.cpp index 4bb0221d..7341b2d0 100644 --- a/src/common/event.cpp +++ b/src/common/event.cpp @@ -87,11 +87,11 @@ Event *Event::fromVariantMap(QVariantMap &map, Network *network) return nullptr; } - EventManager::EventType type = static_cast(inttype); + auto type = static_cast(inttype); if (type == EventManager::Invalid || type == EventManager::GenericEvent) return nullptr; - EventManager::EventType group = static_cast(type & EventManager::EventGroupMask); + auto group = static_cast(type & EventManager::EventGroupMask); Event *e = nullptr; diff --git a/src/common/eventmanager.cpp b/src/common/eventmanager.cpp index 503babf3..606356d6 100644 --- a/src/common/eventmanager.cpp +++ b/src/common/eventmanager.cpp @@ -207,7 +207,7 @@ void EventManager::registerEventHandler(QList events, QObject *object void EventManager::postEvent(Event *event) { if (sender() && sender()->thread() != this->thread()) { - QueuedQuasselEvent *queuedEvent = new QueuedQuasselEvent(event); + auto *queuedEvent = new QueuedQuasselEvent(event); QCoreApplication::postEvent(this, queuedEvent); } else { @@ -223,7 +223,7 @@ void EventManager::postEvent(Event *event) void EventManager::customEvent(QEvent *event) { if (event->type() == QEvent::User) { - QueuedQuasselEvent *queuedEvent = static_cast(event); + auto *queuedEvent = static_cast(event); processEvent(queuedEvent->event); event->accept(); } @@ -258,7 +258,7 @@ void EventManager::dispatchEvent(Event *event) // special handling for numeric IrcEvents if ((type & ~IrcEventNumericMask) == IrcEventNumeric) { - ::IrcEventNumeric *numEvent = static_cast< ::IrcEventNumeric *>(event); + auto *numEvent = static_cast< ::IrcEventNumeric *>(event); if (!numEvent) qWarning() << "Invalid event type for IrcEventNumeric!"; else { diff --git a/src/common/ircchannel.cpp b/src/common/ircchannel.cpp index c4e45d56..7bb83ed4 100644 --- a/src/common/ircchannel.cpp +++ b/src/common/ircchannel.cpp @@ -424,7 +424,7 @@ void IrcChannel::initSetChanModes(const QVariantMap &channelModes) void IrcChannel::ircUserDestroyed() { - IrcUser *ircUser = static_cast(sender()); + auto *ircUser = static_cast(sender()); Q_ASSERT(ircUser); _userModes.remove(ircUser); // no further propagation. @@ -434,7 +434,7 @@ void IrcChannel::ircUserDestroyed() void IrcChannel::ircUserNickSet(QString nick) { - IrcUser *ircUser = qobject_cast(sender()); + auto *ircUser = qobject_cast(sender()); Q_ASSERT(ircUser); emit ircUserNickSet(ircUser, nick); } diff --git a/src/common/ircuser.cpp b/src/common/ircuser.cpp index 52023efb..cf1aedaa 100644 --- a/src/common/ircuser.cpp +++ b/src/common/ircuser.cpp @@ -362,7 +362,7 @@ void IrcUser::quit() void IrcUser::channelDestroyed() { // private slot! - IrcChannel *channel = static_cast(sender()); + auto *channel = static_cast(sender()); if (_channels.contains(channel)) { _channels.remove(channel); if (_channels.isEmpty() && !network()->isMe(this)) diff --git a/src/common/quassel.cpp b/src/common/quassel.cpp index f0f257c1..03cf739a 100644 --- a/src/common/quassel.cpp +++ b/src/common/quassel.cpp @@ -589,8 +589,8 @@ QString Quassel::translationDirPath() void Quassel::loadTranslation(const QLocale &locale) { - QTranslator *qtTranslator = QCoreApplication::instance()->findChild("QtTr"); - QTranslator *quasselTranslator = QCoreApplication::instance()->findChild("QuasselTr"); + auto *qtTranslator = QCoreApplication::instance()->findChild("QtTr"); + auto *quasselTranslator = QCoreApplication::instance()->findChild("QuasselTr"); if (qtTranslator) qApp->removeTranslator(qtTranslator); @@ -669,7 +669,7 @@ Quassel::Features::Features(const QStringList &features, LegacyFeatures legacyFe bool Quassel::Features::isEnabled(Feature feature) const { - size_t i = static_cast(feature); + auto i = static_cast(feature); return i < _features.size() ? _features[i] : false; } diff --git a/src/common/remotepeer.cpp b/src/common/remotepeer.cpp index 31783dc0..d621632f 100644 --- a/src/common/remotepeer.cpp +++ b/src/common/remotepeer.cpp @@ -51,7 +51,7 @@ RemotePeer::RemotePeer(::AuthHandler *authHandler, QTcpSocket *socket, Compresso connect(socket, SIGNAL(disconnected()), SIGNAL(disconnected())); #ifdef HAVE_SSL - QSslSocket *sslSocket = qobject_cast(socket); + auto *sslSocket = qobject_cast(socket); if (sslSocket) connect(sslSocket, SIGNAL(encrypted()), SIGNAL(secureStateChanged())); #endif @@ -168,7 +168,7 @@ bool RemotePeer::isSecure() const if (isLocal()) return true; #ifdef HAVE_SSL - QSslSocket *sslSocket = qobject_cast(socket()); + auto *sslSocket = qobject_cast(socket()); if (sslSocket && sslSocket->isEncrypted()) return true; #endif @@ -260,7 +260,7 @@ bool RemotePeer::readMessage(QByteArray &msg) void RemotePeer::writeMessage(const QByteArray &msg) { - quint32 size = qToBigEndian(msg.size()); + auto size = qToBigEndian(msg.size()); _compressor->write((const char*)&size, 4, Compressor::NoFlush); _compressor->write(msg.constData(), msg.size()); } diff --git a/src/common/serializers/serializers.cpp b/src/common/serializers/serializers.cpp index f0df398b..50509407 100644 --- a/src/common/serializers/serializers.cpp +++ b/src/common/serializers/serializers.cpp @@ -490,7 +490,7 @@ bool Serializers::deserialize(QDataStream &stream, const Quassel::Features &feat allocated += blockSize; } if ((stream.byteOrder() == QDataStream::BigEndian) != (QSysInfo::ByteOrder == QSysInfo::BigEndian)) { - uint16_t *rawData = reinterpret_cast(data.data()); + auto *rawData = reinterpret_cast(data.data()); while (length--) { *rawData = qbswap(*rawData); ++rawData; diff --git a/src/common/signalproxy.cpp b/src/common/signalproxy.cpp index 9a290fca..89355383 100644 --- a/src/common/signalproxy.cpp +++ b/src/common/signalproxy.cpp @@ -388,7 +388,7 @@ void SignalProxy::objectRenamed(const QByteArray &classname, const QString &newn const QMetaObject *SignalProxy::metaObject(const QObject *obj) { - if (const SyncableObject *syncObject = qobject_cast(obj)) + if (const auto *syncObject = qobject_cast(obj)) return syncObject->syncMetaObject(); else return obj->metaObject(); @@ -740,7 +740,7 @@ void SignalProxy::customEvent(QEvent *event) { switch ((int)event->type()) { case RemovePeerEvent: { - ::RemovePeerEvent *e = static_cast< ::RemovePeerEvent *>(event); + auto *e = static_cast< ::RemovePeerEvent *>(event); removePeer(e->peer); event->accept(); break; @@ -788,7 +788,7 @@ void SignalProxy::disconnectDevice(QIODevice *dev, const QString &reason) { if (!reason.isEmpty()) qWarning() << qPrintable(reason); - QAbstractSocket *sock = qobject_cast(dev); + auto *sock = qobject_cast(dev); if (sock) qWarning() << qPrintable(tr("Disconnecting")) << qPrintable(sock->peerAddress().toString()); dev->close(); diff --git a/src/core/core.cpp b/src/core/core.cpp index 6e77294b..35b46b61 100644 --- a/src/core/core.cpp +++ b/src/core/core.cpp @@ -577,7 +577,7 @@ bool Core::initAuthenticator(const QString &backend, const QVariantMap &settings bool Core::sslSupported() { #ifdef HAVE_SSL - SslServer *sslServer = qobject_cast(&instance()->_server); + auto *sslServer = qobject_cast(&instance()->_server); return sslServer && sslServer->isCertValid(); #else return false; @@ -588,10 +588,10 @@ bool Core::sslSupported() bool Core::reloadCerts() { #ifdef HAVE_SSL - SslServer *sslServerv4 = qobject_cast(&_server); + auto *sslServerv4 = qobject_cast(&_server); bool retv4 = sslServerv4->reloadCerts(); - SslServer *sslServerv6 = qobject_cast(&_v6server); + auto *sslServerv6 = qobject_cast(&_v6server); bool retv6 = sslServerv6->reloadCerts(); return retv4 && retv6; @@ -736,12 +736,12 @@ void Core::stopListening(const QString &reason) void Core::incomingConnection() { - QTcpServer *server = qobject_cast(sender()); + auto *server = qobject_cast(sender()); Q_ASSERT(server); while (server->hasPendingConnections()) { QTcpSocket *socket = server->nextPendingConnection(); - CoreAuthHandler *handler = new CoreAuthHandler(socket, this); + auto *handler = new CoreAuthHandler(socket, this); _connectingClients.insert(handler); connect(handler, SIGNAL(disconnected()), SLOT(clientDisconnected())); @@ -760,7 +760,7 @@ void Core::incomingConnection() // Potentially called during the initialization phase (before handing the connection off to the session) void Core::clientDisconnected() { - CoreAuthHandler *handler = qobject_cast(sender()); + auto *handler = qobject_cast(sender()); Q_ASSERT(handler); quInfo() << qPrintable(tr("Non-authed client disconnected:")) << qPrintable(handler->socket()->peerAddress().toString()); @@ -779,7 +779,7 @@ void Core::clientDisconnected() void Core::setupClientSession(RemotePeer *peer, UserId uid) { - CoreAuthHandler *handler = qobject_cast(sender()); + auto *handler = qobject_cast(sender()); Q_ASSERT(handler); // From now on everything is handled by the client session @@ -799,7 +799,7 @@ void Core::setupClientSession(RemotePeer *peer, UserId uid) void Core::customEvent(QEvent *event) { if (event->type() == AddClientEventId) { - AddClientEvent *addClientEvent = static_cast(event); + auto *addClientEvent = static_cast(event); addClientHelper(addClientEvent->peer, addClientEvent->userId); return; } @@ -851,7 +851,7 @@ void Core::setupInternalClientSession(QPointer clientPeer) return; } - InternalPeer *corePeer = new InternalPeer(this); + auto *corePeer = new InternalPeer(this); corePeer->setPeer(clientPeer); clientPeer->setPeer(corePeer); @@ -1181,7 +1181,7 @@ std::unique_ptr Core::getMigrationReader(Storage *st if (!storage) return nullptr; - AbstractSqlStorage *sqlStorage = qobject_cast(storage); + auto *sqlStorage = qobject_cast(storage); if (!sqlStorage) { qDebug() << "Core::migrateDb(): only SQL based backends can be migrated!"; return nullptr; @@ -1196,7 +1196,7 @@ std::unique_ptr Core::getMigrationWriter(Storage *st if (!storage) return nullptr; - AbstractSqlStorage *sqlStorage = qobject_cast(storage); + auto *sqlStorage = qobject_cast(storage); if (!sqlStorage) { qDebug() << "Core::migrateDb(): only SQL based backends can be migrated!"; return nullptr; diff --git a/src/core/corealiasmanager.cpp b/src/core/corealiasmanager.cpp index dc6f037c..0a7faa15 100644 --- a/src/core/corealiasmanager.cpp +++ b/src/core/corealiasmanager.cpp @@ -27,7 +27,7 @@ CoreAliasManager::CoreAliasManager(CoreSession *parent) : AliasManager(parent) { - CoreSession *session = qobject_cast(parent); + auto *session = qobject_cast(parent); if (!session) { qWarning() << "CoreAliasManager: unable to load Aliases. Parent is not a Coresession!"; loadDefaults(); @@ -45,7 +45,7 @@ CoreAliasManager::CoreAliasManager(CoreSession *parent) void CoreAliasManager::save() const { - CoreSession *session = qobject_cast(parent()); + auto *session = qobject_cast(parent()); if (!session) { qWarning() << "CoreAliasManager: unable to save Aliases. Parent is not a Coresession!"; return; diff --git a/src/core/coreauthhandler.cpp b/src/core/coreauthhandler.cpp index a4baf5f4..369a1348 100644 --- a/src/core/coreauthhandler.cpp +++ b/src/core/coreauthhandler.cpp @@ -86,8 +86,8 @@ void CoreAuthHandler::onReadyRead() socket()->read((char*)&data, 4); data = qFromBigEndian(data); - Protocol::Type type = static_cast(data & 0xff); - quint16 protoFeatures = static_cast(data>>8 & 0xffff); + auto type = static_cast(data & 0xff); + auto protoFeatures = static_cast(data>>8 & 0xffff); _supportedProtos.append(PeerFactory::ProtoDescriptor(type, protoFeatures)); if (data >= 0x80000000) { // last protocol @@ -270,7 +270,7 @@ void CoreAuthHandler::handle(const Login &msg) void CoreAuthHandler::startSsl() { #ifdef HAVE_SSL - QSslSocket *sslSocket = qobject_cast(socket()); + auto *sslSocket = qobject_cast(socket()); Q_ASSERT(sslSocket); qDebug() << qPrintable(tr("Starting encryption for Client:")) << _peer->description(); @@ -284,7 +284,7 @@ void CoreAuthHandler::startSsl() #ifdef HAVE_SSL void CoreAuthHandler::onSslErrors() { - QSslSocket *sslSocket = qobject_cast(socket()); + auto *sslSocket = qobject_cast(socket()); Q_ASSERT(sslSocket); sslSocket->ignoreSslErrors(); } diff --git a/src/core/coreignorelistmanager.cpp b/src/core/coreignorelistmanager.cpp index c6c3a7ab..0694b86e 100644 --- a/src/core/coreignorelistmanager.cpp +++ b/src/core/coreignorelistmanager.cpp @@ -26,7 +26,7 @@ CoreIgnoreListManager::CoreIgnoreListManager(CoreSession *parent) : IgnoreListManager(parent) { - CoreSession *session = qobject_cast(parent); + auto *session = qobject_cast(parent); if (!session) { qWarning() << "CoreIgnoreListManager: unable to load IgnoreList. Parent is not a Coresession!"; //loadDefaults(); @@ -52,7 +52,7 @@ IgnoreListManager::StrictnessType CoreIgnoreListManager::match(const RawMessage void CoreIgnoreListManager::save() const { - CoreSession *session = qobject_cast(parent()); + auto *session = qobject_cast(parent()); if (!session) { qWarning() << "CoreIgnoreListManager: unable to save IgnoreList. Parent is not a Coresession!"; return; diff --git a/src/core/coreircchannel.cpp b/src/core/coreircchannel.cpp index 8bce68f4..faf249de 100644 --- a/src/core/coreircchannel.cpp +++ b/src/core/coreircchannel.cpp @@ -29,7 +29,7 @@ CoreIrcChannel::CoreIrcChannel(const QString &channelname, Network *network) _cipher = nullptr; // Get the cipher key from CoreNetwork if present - CoreNetwork *coreNetwork = qobject_cast(network); + auto *coreNetwork = qobject_cast(network); if (coreNetwork) { QByteArray key = coreNetwork->readChannelCipherKey(channelname); if (!key.isEmpty()) { @@ -47,7 +47,7 @@ CoreIrcChannel::~CoreIrcChannel() // exists. There is no need to store the empty key if no cipher exists; no // key was present when instantiating and no key was set during the // channel's lifetime. - CoreNetwork *coreNetwork = qobject_cast(network()); + auto *coreNetwork = qobject_cast(network()); if (coreNetwork && _cipher) { coreNetwork->storeChannelCipherKey(name(), _cipher->key()); } diff --git a/src/core/coreircuser.cpp b/src/core/coreircuser.cpp index b9dd830f..12ead6d2 100644 --- a/src/core/coreircuser.cpp +++ b/src/core/coreircuser.cpp @@ -27,7 +27,7 @@ CoreIrcUser::CoreIrcUser(const QString &hostmask, Network *network) : IrcUser(ho _cipher = nullptr; // Get the cipher key from CoreNetwork if present - CoreNetwork *coreNetwork = qobject_cast(network); + auto *coreNetwork = qobject_cast(network); if (coreNetwork) { QByteArray key = coreNetwork->readChannelCipherKey(nick().toLower()); if (!key.isEmpty()) { @@ -48,7 +48,7 @@ CoreIrcUser::~CoreIrcUser() // exists. There is no need to store the empty key if no cipher exists; no // key was present when instantiating and no key was set during the // channel's lifetime. - CoreNetwork *coreNetwork = qobject_cast(network()); + auto *coreNetwork = qobject_cast(network()); if (coreNetwork && _cipher) { coreNetwork->storeChannelCipherKey(nick().toLower(), _cipher->key()); } diff --git a/src/core/corenetwork.cpp b/src/core/corenetwork.cpp index 143760f8..f0a4e306 100644 --- a/src/core/corenetwork.cpp +++ b/src/core/corenetwork.cpp @@ -443,11 +443,11 @@ Cipher *CoreNetwork::cipher(const QString &target) if (!Cipher::neededFeaturesAvailable()) return nullptr; - CoreIrcChannel *channel = qobject_cast(ircChannel(target)); + auto *channel = qobject_cast(ircChannel(target)); if (channel) { return channel->cipher(); } - CoreIrcUser *user = qobject_cast(ircUser(target)); + auto *user = qobject_cast(ircUser(target)); if (user) { return user->cipher(); } else if (!isChannelName(target)) { @@ -459,11 +459,11 @@ Cipher *CoreNetwork::cipher(const QString &target) QByteArray CoreNetwork::cipherKey(const QString &target) const { - CoreIrcChannel *c = qobject_cast(ircChannel(target)); + auto *c = qobject_cast(ircChannel(target)); if (c) return c->cipher()->key(); - CoreIrcUser *u = qobject_cast(ircUser(target)); + auto *u = qobject_cast(ircUser(target)); if (u) return u->cipher()->key(); @@ -473,14 +473,14 @@ QByteArray CoreNetwork::cipherKey(const QString &target) const void CoreNetwork::setCipherKey(const QString &target, const QByteArray &key) { - CoreIrcChannel *c = qobject_cast(ircChannel(target)); + auto *c = qobject_cast(ircChannel(target)); if (c) { c->setEncrypted(c->cipher()->setKey(key)); coreSession()->setBufferCipher(networkId(), target, key); return; } - CoreIrcUser *u = qobject_cast(ircUser(target)); + auto *u = qobject_cast(ircUser(target)); if (!u && !isChannelName(target)) u = qobject_cast(newIrcUser(target)); @@ -494,10 +494,10 @@ void CoreNetwork::setCipherKey(const QString &target, const QByteArray &key) bool CoreNetwork::cipherUsesCBC(const QString &target) { - CoreIrcChannel *c = qobject_cast(ircChannel(target)); + auto *c = qobject_cast(ircChannel(target)); if (c) return c->cipher()->usesCBC(); - CoreIrcUser *u = qobject_cast(ircUser(target)); + auto *u = qobject_cast(ircUser(target)); if (u) return u->cipher()->usesCBC(); diff --git a/src/core/corenetworkconfig.cpp b/src/core/corenetworkconfig.cpp index 3ae0ae0c..faab93ed 100644 --- a/src/core/corenetworkconfig.cpp +++ b/src/core/corenetworkconfig.cpp @@ -38,7 +38,7 @@ CoreNetworkConfig::CoreNetworkConfig(const QString &objectName, CoreSession *ses void CoreNetworkConfig::save() { - CoreSession *session = qobject_cast(parent()); + auto *session = qobject_cast(parent()); if (!session) { qWarning() << Q_FUNC_INFO << "No CoreSession set, cannot save network configuration!"; return; diff --git a/src/core/coresession.cpp b/src/core/coresession.cpp index faec85de..ab4859b2 100644 --- a/src/core/coresession.cpp +++ b/src/core/coresession.cpp @@ -275,7 +275,7 @@ void CoreSession::addClient(InternalPeer *peer) void CoreSession::removeClient(Peer *peer) { - RemotePeer *p = qobject_cast(peer); + auto *p = qobject_cast(peer); if (p) quInfo() << qPrintable(tr("Client")) << p->description() << qPrintable(tr("disconnected (UserId: %1).").arg(user().toInt())); _coreInfo->setConnectedClientData(signalProxy()->peerCount(), signalProxy()->peerData()); @@ -344,7 +344,7 @@ void CoreSession::recvMessageFromServer(NetworkId networkId, Message::Type type, void CoreSession::recvStatusMsgFromServer(QString msg) { - CoreNetwork *net = qobject_cast(sender()); + auto *net = qobject_cast(sender()); Q_ASSERT(net); emit displayStatusMsg(net->networkName(), msg); } @@ -562,7 +562,7 @@ const QString CoreSession::strictCompliantIdent(const CoreIdentity *identity) { void CoreSession::createIdentity(const CoreIdentity &identity) { - CoreIdentity *coreIdentity = new CoreIdentity(identity, this); + auto *coreIdentity = new CoreIdentity(identity, this); _identities[identity.id()] = coreIdentity; // CoreIdentity has its own synchronize method since its "private" sslManager needs to be synced as well coreIdentity->synchronize(signalProxy()); @@ -573,7 +573,7 @@ void CoreSession::createIdentity(const CoreIdentity &identity) void CoreSession::updateIdentityBySender() { - CoreIdentity *identity = qobject_cast(sender()); + auto *identity = qobject_cast(sender()); if (!identity) return; Core::updateIdentity(user(), *identity); diff --git a/src/core/coresessioneventprocessor.cpp b/src/core/coresessioneventprocessor.cpp index 04233f34..31e7cf2f 100644 --- a/src/core/coresessioneventprocessor.cpp +++ b/src/core/coresessioneventprocessor.cpp @@ -801,7 +801,7 @@ void CoreSessionEventProcessor::processKeyEvent(KeyEvent *e) emit newEvent(new MessageEvent(Message::Error, e->network(), tr("Unable to perform key exchange, missing qca-ossl plugin."), e->prefix(), e->target(), Message::None, e->timestamp())); return; } - CoreNetwork *net = qobject_cast(e->network()); + auto *net = qobject_cast(e->network()); Cipher *c = net->cipher(e->target()); if (!c) // happens when there is no CoreIrcChannel for the target (i.e. never?) return; @@ -1478,7 +1478,7 @@ void CoreSessionEventProcessor::handleEarlyNetsplitJoin(Network *net, const QStr void CoreSessionEventProcessor::handleNetsplitFinished() { - Netsplit *n = qobject_cast(sender()); + auto *n = qobject_cast(sender()); Q_ASSERT(n); QHash splithash = _netsplits.take(n->network()); splithash.remove(splithash.key(n)); diff --git a/src/core/identserver.cpp b/src/core/identserver.cpp index 5e728746..8a52520b 100644 --- a/src/core/identserver.cpp +++ b/src/core/identserver.cpp @@ -101,7 +101,7 @@ void IdentServer::incomingConnection() void IdentServer::respond() { - QTcpSocket *socket = qobject_cast(sender()); + auto *socket = qobject_cast(sender()); Q_ASSERT(socket); qint64 transactionId = _socketId; diff --git a/src/core/ircparser.cpp b/src/core/ircparser.cpp index 25d16f81..5c6fce76 100644 --- a/src/core/ircparser.cpp +++ b/src/core/ircparser.cpp @@ -82,7 +82,7 @@ QByteArray IrcParser::decrypt(Network *network, const QString &bufferName, const /* used to be handleServerMsg() */ void IrcParser::processNetworkIncoming(NetworkDataEvent *e) { - CoreNetwork *net = qobject_cast(e->network()); + auto *net = qobject_cast(e->network()); if (!net) { qWarning() << "Received network event without valid network pointer!"; return; diff --git a/src/core/postgresqlstorage.cpp b/src/core/postgresqlstorage.cpp index 6b971042..c414b876 100644 --- a/src/core/postgresqlstorage.cpp +++ b/src/core/postgresqlstorage.cpp @@ -1583,7 +1583,7 @@ int PostgreSqlStorage::highlightCount(BufferId bufferId, MsgId lastSeenMsgId) query.bindValue(":lastseenmsgid", lastSeenMsgId.toQint64()); safeExec(query); watchQuery(query); - int result = int(0); + auto result = int(0); if (query.first()) result = query.value(0).toInt(); return result; diff --git a/src/core/sslserver.cpp b/src/core/sslserver.cpp index 1d5a103d..b8c010fa 100644 --- a/src/core/sslserver.cpp +++ b/src/core/sslserver.cpp @@ -73,7 +73,7 @@ QTcpSocket *SslServer::nextPendingConnection() void SslServer::incomingConnection(qintptr socketDescriptor) { - QSslSocket *serverSocket = new QSslSocket(this); + auto *serverSocket = new QSslSocket(this); if (serverSocket->setSocketDescriptor(socketDescriptor)) { if (isCertValid()) { serverSocket->setLocalCertificate(_cert); diff --git a/src/qtui/bufferwidget.cpp b/src/qtui/bufferwidget.cpp index aa700f9f..f7af4839 100644 --- a/src/qtui/bufferwidget.cpp +++ b/src/qtui/bufferwidget.cpp @@ -75,26 +75,26 @@ BufferWidget::BufferWidget(QWidget *parent) ActionCollection *coll = QtUi::actionCollection(); - Action *zoomInChatview = coll->add("ZoomInChatView", this, SLOT(zoomIn())); + auto *zoomInChatview = coll->add("ZoomInChatView", this, SLOT(zoomIn())); zoomInChatview->setText(tr("Zoom In")); zoomInChatview->setIcon(icon::get("zoom-in")); zoomInChatview->setShortcut(QKeySequence::ZoomIn); - Action *zoomOutChatview = coll->add("ZoomOutChatView", this, SLOT(zoomOut())); + auto *zoomOutChatview = coll->add("ZoomOutChatView", this, SLOT(zoomOut())); zoomOutChatview->setIcon(icon::get("zoom-out")); zoomOutChatview->setText(tr("Zoom Out")); zoomOutChatview->setShortcut(QKeySequence::ZoomOut); - Action *zoomOriginalChatview = coll->add("ZoomOriginalChatView", this, SLOT(zoomOriginal())); + auto *zoomOriginalChatview = coll->add("ZoomOriginalChatView", this, SLOT(zoomOriginal())); zoomOriginalChatview->setIcon(icon::get("zoom-original")); zoomOriginalChatview->setText(tr("Actual Size")); //zoomOriginalChatview->setShortcut(QKeySequence(Qt::CTRL + Qt::Key_0)); // used for RTS switching - Action *setMarkerLine = coll->add("SetMarkerLineToBottom", this, SLOT(setMarkerLine())); + auto *setMarkerLine = coll->add("SetMarkerLineToBottom", this, SLOT(setMarkerLine())); setMarkerLine->setText(tr("Set Marker Line")); setMarkerLine->setShortcut(QKeySequence(Qt::CTRL + Qt::Key_R)); - Action *jumpToMarkerLine = QtUi::actionCollection("Navigation")->add("JumpToMarkerLine", this, SLOT(jumpToMarkerLine())); + auto *jumpToMarkerLine = QtUi::actionCollection("Navigation")->add("JumpToMarkerLine", this, SLOT(jumpToMarkerLine())); jumpToMarkerLine->setText(tr("Go to Marker Line")); jumpToMarkerLine->setShortcut(QKeySequence(Qt::CTRL + Qt::Key_K)); @@ -150,7 +150,7 @@ void BufferWidget::showChatView(BufferId id) ui.stackedWidget->setCurrentWidget(ui.page); } else { - ChatView *view = qobject_cast(_chatViews.value(id)); + auto *view = qobject_cast(_chatViews.value(id)); Q_ASSERT(view); ui.stackedWidget->setCurrentWidget(view); _chatViewSearchController->setScene(view->scene()); @@ -160,7 +160,7 @@ void BufferWidget::showChatView(BufferId id) void BufferWidget::scrollToHighlight(QGraphicsItem *highlightItem) { - ChatView *view = qobject_cast(ui.stackedWidget->currentWidget()); + auto *view = qobject_cast(ui.stackedWidget->currentWidget()); if (view) { view->centerOn(highlightItem); } @@ -169,7 +169,7 @@ void BufferWidget::scrollToHighlight(QGraphicsItem *highlightItem) void BufferWidget::zoomIn() { - ChatView *view = qobject_cast(ui.stackedWidget->currentWidget()); + auto *view = qobject_cast(ui.stackedWidget->currentWidget()); if (view) view->zoomIn(); } @@ -177,7 +177,7 @@ void BufferWidget::zoomIn() void BufferWidget::zoomOut() { - ChatView *view = qobject_cast(ui.stackedWidget->currentWidget()); + auto *view = qobject_cast(ui.stackedWidget->currentWidget()); if (view) view->zoomOut(); } @@ -185,7 +185,7 @@ void BufferWidget::zoomOut() void BufferWidget::zoomOriginal() { - ChatView *view = qobject_cast(ui.stackedWidget->currentWidget()); + auto *view = qobject_cast(ui.stackedWidget->currentWidget()); if (view) view->zoomOriginal(); } @@ -207,9 +207,9 @@ bool BufferWidget::eventFilter(QObject *watched, QEvent *event) if (event->type() != QEvent::KeyPress) return false; - QKeyEvent *keyEvent = static_cast(event); + auto *keyEvent = static_cast(event); - MultiLineEdit *inputLine = qobject_cast(watched); + auto *inputLine = qobject_cast(watched); if (!inputLine) return false; @@ -217,7 +217,7 @@ bool BufferWidget::eventFilter(QObject *watched, QEvent *event) if (keyEvent == QKeySequence::Copy) { if (inputLine->hasSelectedText()) return false; - ChatView *view = qobject_cast(ui.stackedWidget->currentWidget()); + auto *view = qobject_cast(ui.stackedWidget->currentWidget()); if (view) view->scene()->selectionToClipboard(); return true; @@ -245,12 +245,12 @@ bool BufferWidget::eventFilter(QObject *watched, QEvent *event) void BufferWidget::currentChanged(const QModelIndex ¤t, const QModelIndex &previous) { - ChatView *prevView = qobject_cast(ui.stackedWidget->currentWidget()); + auto *prevView = qobject_cast(ui.stackedWidget->currentWidget()); AbstractBufferContainer::currentChanged(current, previous); // switch first to avoid a redraw // we need to hide the marker line if it's already/still at the bottom of the view (and not scrolled up) - ChatView *curView = qobject_cast(ui.stackedWidget->currentWidget()); + auto *curView = qobject_cast(ui.stackedWidget->currentWidget()); if (curView) { BufferId curBufferId = current.data(NetworkModel::BufferIdRole).value(); if (curBufferId.isValid()) { diff --git a/src/qtui/chatitem.cpp b/src/qtui/chatitem.cpp index b88ac27e..cda1fd8f 100644 --- a/src/qtui/chatitem.cpp +++ b/src/qtui/chatitem.cpp @@ -297,7 +297,7 @@ QVector ChatItem::additionalFormats() const using Label = UiStyle::MessageLabel; using Format = UiStyle::Format; - Label itemLabel = data(ChatLineModel::MsgLabelRole).value