From: Shane Synan <digitalcircuit36939@gmail.com>
Date: Thu, 30 May 2019 20:19:18 +0000 (-0400)
Subject: tests: Verify ExpressionMatch test data won't OOB
X-Git-Tag: test-travis-01~55
X-Git-Url: https://git.quassel-irc.org/?p=quassel.git;a=commitdiff_plain;h=dd1d9d68c406b993230161208cbd17db55dc85a9;hp=dd1d9d68c406b993230161208cbd17db55dc85a9

tests: Verify ExpressionMatch test data won't OOB

Verify that the ExpressionMatch test data for test
trimMultiWildcardWhitespace won't try to access out of bounds data by
changing EXPECT to ASSERT for patternPair.size() == 2.

If the test data is wrong, the results will be undefined, so there's
no point in continuing the test.

Alternative: use std::vector's .at() function, which will raise a
runtime error if out of bounds.
---