From: Jan Alexander Steffens (heftig) <jan.steffens@gmail.com>
Date: Sat, 19 May 2018 10:29:42 +0000 (+0200)
Subject: identd: Turn !canReadLine into an early return
X-Git-Tag: 0.13-rc1~51
X-Git-Url: https://git.quassel-irc.org/?p=quassel.git;a=commitdiff_plain;h=d7eb7e8b9c1304289da42b576cd054fa7422ab46

identd: Turn !canReadLine into an early return

Reduces rightward drift.
---

diff --git a/src/core/identserver.cpp b/src/core/identserver.cpp
index ffb2f150..13b32fa6 100644
--- a/src/core/identserver.cpp
+++ b/src/core/identserver.cpp
@@ -96,31 +96,33 @@ void IdentServer::respond() {
 
     qint64 transactionId = _socketId;
 
-    if (socket->canReadLine()) {
-        QByteArray query = socket->readLine();
-        if (query.endsWith("\r\n"))
-            query.chop(2);
-        else if (query.endsWith("\n"))
-            query.chop(1);
+    if (!socket->canReadLine()) {
+        return;
+    }
 
-        QList<QByteArray> split = query.split(',');
+    QByteArray query = socket->readLine();
+    if (query.endsWith("\r\n"))
+        query.chop(2);
+    else if (query.endsWith("\n"))
+        query.chop(1);
 
-        bool success = false;
+    QList<QByteArray> split = query.split(',');
 
-        quint16 localPort;
-        if (!split.empty()) {
-            localPort = split[0].trimmed().toUShort(&success, 10);
-        }
+    bool success = false;
 
-        Request request{socket, localPort, query, transactionId, _requestId++};
-        if (!success) {
+    quint16 localPort;
+    if (!split.empty()) {
+        localPort = split[0].trimmed().toUShort(&success, 10);
+    }
+
+    Request request{socket, localPort, query, transactionId, _requestId++};
+    if (!success) {
+        responseUnavailable(request);
+    } else if (!responseAvailable(request)) {
+        if (hasSocketsBelowId(transactionId)) {
+            _requestQueue.emplace_back(request);
+        } else {
             responseUnavailable(request);
-        } else if (!responseAvailable(request)) {
-            if (hasSocketsBelowId(transactionId)) {
-                _requestQueue.emplace_back(request);
-            } else {
-                responseUnavailable(request);
-            }
         }
     }
 }