From: Manuel Nickschas <sputnick@quassel-irc.org>
Date: Thu, 8 Sep 2011 18:33:12 +0000 (+0200)
Subject: Fix core crash
X-Git-Tag: 0.7.3~1
X-Git-Url: https://git.quassel-irc.org/?p=quassel.git;a=commitdiff_plain;h=cb49ea7449247ecb5d7081e25309c1f166e25732

Fix core crash

Some CTCP requests could make the core crash; this fixes it.
---

diff --git a/src/core/ctcphandler.cpp b/src/core/ctcphandler.cpp
index 5853ff88..f67735fd 100644
--- a/src/core/ctcphandler.cpp
+++ b/src/core/ctcphandler.cpp
@@ -198,13 +198,10 @@ void CtcpHandler::packedReply(const QString &bufname, const QList<QByteArray> &r
     answerSize += replies.at(i).size();
   }
 
-  QByteArray quotedReply(answerSize, 0);
-  int nextPos = 0;
-  QByteArray &reply = quotedReply;
+  QByteArray quotedReply;
+  quotedReply.reserve(answerSize);
   for(int i = 0; i < replies.count(); i++) {
-    reply = replies.at(i);
-    quotedReply.replace(nextPos, reply.size(), reply);
-    nextPos += reply.size();
+    quotedReply.append(replies.at(i));
   }
 
   params << serverEncode(bufname) << quotedReply;