From: Manuel Nickschas <sputnick@quassel-irc.org>
Date: Wed, 10 Feb 2016 18:58:52 +0000 (+0100)
Subject: Don't prefix the nick with a colon while connecting to a server
X-Git-Tag: travis-deploy-test~521
X-Git-Url: https://git.quassel-irc.org/?p=quassel.git;a=commitdiff_plain;h=b9119a8251fdac5f0b7452b5576583eebe71a402

Don't prefix the nick with a colon while connecting to a server

For the NICK command during the initial connection handshake, we
always prefixed the parameter with a colon. While this is not an RFC
violation, it is unnecessary as nicks can't contain spaces. Worse, it
confuses some obscure ircds...
---

diff --git a/src/core/corenetwork.cpp b/src/core/corenetwork.cpp
index dd1bf2e7..a6dc7855 100644
--- a/src/core/corenetwork.cpp
+++ b/src/core/corenetwork.cpp
@@ -496,7 +496,7 @@ void CoreNetwork::socketInitialized()
     else {
         nick = identity->nicks()[0];
     }
-    putRawLine(serverEncode(QString("NICK :%1").arg(nick)));
+    putRawLine(serverEncode(QString("NICK %1").arg(nick)));
     putRawLine(serverEncode(QString("USER %1 8 * :%2").arg(identity->ident(), identity->realName())));
 }