From: Albert S <mail@quitesimple.org>
Date: Mon, 21 Aug 2017 19:35:41 +0000 (+0200)
Subject: core: connectToIrc: Add clarifying comment on DNS lookups
X-Git-Tag: travis-deploy-test~194
X-Git-Url: https://git.quassel-irc.org/?p=quassel.git;a=commitdiff_plain;h=a6c3d4252d760a6de70cb000cc3d6ee34a36eb31

core: connectToIrc: Add clarifying comment on DNS lookups

Closes GH-298.
---

diff --git a/src/core/corenetwork.cpp b/src/core/corenetwork.cpp
index f77b29aa..24be4c1a 100644
--- a/src/core/corenetwork.cpp
+++ b/src/core/corenetwork.cpp
@@ -242,8 +242,10 @@ void CoreNetwork::connectToIrc(bool reconnecting)
     // Qt caches DNS entries for a minute, resulting in round-robin (e.g. for chat.freenode.net) not working if several users
     // connect at a similar time. QHostInfo::fromName(), however, always performs a fresh lookup, overwriting the cache entry.
     if (! server.useProxy) {
-		QHostInfo::fromName(server.host);
-	}
+        //Avoid hostname lookups when a proxy is specified. The lookups won't use the proxy and may therefore leak the DNS
+        //hostname of the server. Qt's DNS cache also isn't used by the proxy so we don't need to refresh the entry.
+        QHostInfo::fromName(server.host);
+    }
 #ifdef HAVE_SSL
     if (server.useSsl) {
         CoreIdentity *identity = identityPtr();