From: Jan Alexander Steffens (heftig) <jan.steffens@gmail.com>
Date: Sat, 19 May 2018 10:29:43 +0000 (+0200)
Subject: identd: Simplify responseAvailable via early return
X-Git-Tag: 0.13-rc1~48
X-Git-Url: https://git.quassel-irc.org/?p=quassel.git;a=commitdiff_plain;h=a5ee609b02cb8d7ebb43b0034a6d50838c426f0b

identd: Simplify responseAvailable via early return
---

diff --git a/src/core/identserver.cpp b/src/core/identserver.cpp
index cb72a256..6d23a6ca 100644
--- a/src/core/identserver.cpp
+++ b/src/core/identserver.cpp
@@ -128,23 +128,18 @@ void IdentServer::respond() {
 }
 
 bool IdentServer::responseAvailable(Request request) {
-    QString user;
-    bool success = true;
-    if (_connections.contains(request.localPort)) {
-        user = _connections[request.localPort];
-    } else {
-        success = false;
+    if (!_connections.contains(request.localPort)) {
+        return false;
     }
 
-    QString data;
-    if (success) {
-        data += request.query + " : USERID : Quassel : " + user + "\r\n";
+    QString user = _connections[request.localPort];
+    QString data = request.query + " : USERID : Quassel : " + user + "\r\n";
 
-        request.socket->write(data.toUtf8());
-        request.socket->flush();
-        request.socket->close();
-    }
-    return success;
+    request.socket->write(data.toUtf8());
+    request.socket->flush();
+    request.socket->close();
+
+    return true;
 }
 
 void IdentServer::responseUnavailable(Request request) {