From: Diego 'Flameeyes' Pettenò <flameeyes@gmail.com>
Date: Mon, 16 Jun 2008 17:55:58 +0000 (+0200)
Subject: Fix warnings about non-string-literals on printf()-like functions.
X-Git-Tag: 0.2.0-rc1~57
X-Git-Url: https://git.quassel-irc.org/?p=quassel.git;a=commitdiff_plain;h=a3175e452523f96a16dc8b669a33a060af5700fb

Fix warnings about non-string-literals on printf()-like functions.

qWarning() and similar functions expect a format string as first
parameter.

Using QString's formatting, you should not pass it as first parameter,
but use the "%s" format instead. It's very difficult but it might lead
to format string vulnerabilities.

Signed-off-by: Manuel Nickschas <sputnick@quassel-irc.org>
---

diff --git a/src/common/genversion.cpp b/src/common/genversion.cpp
index e8e75f9f..e48d494a 100644
--- a/src/common/genversion.cpp
+++ b/src/common/genversion.cpp
@@ -75,7 +75,7 @@ int main(int argc, char **argv) {
   // ok, create our version.gen now
   QFile gen(target);
   if(!gen.open(QIODevice::WriteOnly | QIODevice::Text)) {
-    qFatal(QString("Could not write %1!").arg(target).toAscii());
+    qFatal("%s", qPrintable(QString("Could not write %1!").arg(target)));
     return 255;
   }
   gen.write(QString("quasselGeneratedVersion = \"%1\";\n"
diff --git a/src/common/main.cpp b/src/common/main.cpp
index e7387355..64433f0c 100644
--- a/src/common/main.cpp
+++ b/src/common/main.cpp
@@ -54,7 +54,7 @@
 
 //! Signal handler for graceful shutdown.
 void handle_signal(int sig) {
-  qWarning(QString("Caught signal %1 - exiting.").arg(sig).toAscii());
+  qWarning("%s", qPrintable(QString("Caught signal %1 - exiting.").arg(sig)));
   QCoreApplication::quit();
 }
 
diff --git a/src/core/core.cpp b/src/core/core.cpp
index cd636321..776a8b48 100644
--- a/src/core/core.cpp
+++ b/src/core/core.cpp
@@ -333,7 +333,7 @@ QHash<BufferId, MsgId> Core::bufferLastSeenMsgIds(UserId user) {
 
 bool Core::startListening(uint port) {
   if(!server.listen(QHostAddress::Any, port)) {
-    qWarning(qPrintable(QString("Could not open GUI client port %1: %2").arg(port).arg(server.errorString())));
+    qWarning("%s", qPrintable(QString("Could not open GUI client port %1: %2").arg(port).arg(server.errorString())));
     return false;
   }
   qDebug() << "Listening for GUI clients on port" << server.serverPort();
diff --git a/src/uisupport/uistyle.cpp b/src/uisupport/uistyle.cpp
index 94c9742b..75b5e0c0 100644
--- a/src/uisupport/uistyle.cpp
+++ b/src/uisupport/uistyle.cpp
@@ -199,7 +199,7 @@ UiStyle::StyledText UiStyle::styleString(const QString &_s) {
       if(s[pos+1] == 'D') code += s[pos+2];
       FormatType ftype = formatType(code);
       if(ftype == Invalid) {
-        qWarning(qPrintable(QString("Invalid format code in string: %1").arg(s)));
+        qWarning("%s", qPrintable(QString("Invalid format code in string: %1").arg(s)));
         continue;
       }
       //Q_ASSERT(ftype != Invalid);