From: Manuel Nickschas <sputnick@quassel-irc.org>
Date: Fri, 18 Apr 2008 17:48:09 +0000 (+0000)
Subject: Merging r774:778 from trunk into branches/0.3. Forwardporting hopefully the last... 
X-Git-Tag: 0.3.0~425^2~22
X-Git-Url: https://git.quassel-irc.org/?p=quassel.git;a=commitdiff_plain;h=6cd120c0b28d9cca7e2465fad731977d532ce74d

Merging r774:778 from trunk into branches/0.3. Forwardporting hopefully the last fixes for the custom view fallout.
---

diff --git a/src/client/buffermodel.cpp b/src/client/buffermodel.cpp
index 3dfdc6da..b67a447d 100644
--- a/src/client/buffermodel.cpp
+++ b/src/client/buffermodel.cpp
@@ -30,6 +30,10 @@ BufferModel::BufferModel(NetworkModel *parent)
     _selectionModelSynchronizer(this)
 {
   setSourceModel(parent);
+  if(QCoreApplication::instance()->arguments().contains("--debugbufferswitches")) {
+    connect(_selectionModelSynchronizer.selectionModel(), SIGNAL(currentChanged(const QModelIndex &, const QModelIndex &)),
+	    this, SLOT(debug_currentChanged(const QModelIndex &, const QModelIndex &)));
+  }
 }
 
 bool BufferModel::filterAcceptsRow(int sourceRow, const QModelIndex &parent) const {
@@ -60,14 +64,11 @@ QModelIndex BufferModel::currentIndex() {
 }
 
 void BufferModel::setCurrentIndex(const QModelIndex &newCurrent) {
-  _selectionModelSynchronizer.selectionModel()->setCurrentIndex(newCurrent, QItemSelectionModel::ClearAndSelect | QItemSelectionModel::Rows);
-  _selectionModelSynchronizer.selectionModel()->select(newCurrent, QItemSelectionModel::Current);
+  _selectionModelSynchronizer.selectionModel()->setCurrentIndex(newCurrent, QItemSelectionModel::Current);
+  _selectionModelSynchronizer.selectionModel()->select(newCurrent, QItemSelectionModel::ClearAndSelect | QItemSelectionModel::Rows);
 }
 
 void BufferModel::debug_currentChanged(QModelIndex current, QModelIndex previous) {
-  qDebug() << "New current:" << current << "(previous:" << previous << ")";
-}
-
-void BufferModel::debug_selectionChanged(QItemSelection current , QItemSelection previous) {
-  qDebug() << "new selection:" << current << "(previoius:" << previous << ")";
+  Q_UNUSED(previous);
+  qDebug() << "Switched current Buffer: " << current << current.data().toString() << "Buffer:" << current.data(NetworkModel::BufferIdRole).value<BufferId>();
 }
diff --git a/src/client/buffermodel.h b/src/client/buffermodel.h
index 3126f737..7bd3fc9e 100644
--- a/src/client/buffermodel.h
+++ b/src/client/buffermodel.h
@@ -50,7 +50,6 @@ public:
 
 private slots:
   void debug_currentChanged(QModelIndex current, QModelIndex previous);
-  void debug_selectionChanged(QItemSelection current , QItemSelection previous);
     
 private:
   SelectionModelSynchronizer _selectionModelSynchronizer;
diff --git a/src/client/treemodel.cpp b/src/client/treemodel.cpp
index 9a919803..6fc0c25b 100644
--- a/src/client/treemodel.cpp
+++ b/src/client/treemodel.cpp
@@ -399,9 +399,6 @@ QVariant TreeModel::data(const QModelIndex &index, int role) const {
     return QVariant();
 
   AbstractTreeItem *item = static_cast<AbstractTreeItem *>(index.internalPointer());
-  if(role == Qt::DisplayRole && !item->data(index.column(), role).isValid()) {
-    qDebug() << item->data(0, role) << item->columnCount();
-  }
   return item->data(index.column(), role);
 }
 
diff --git a/src/uisupport/bufferview.cpp b/src/uisupport/bufferview.cpp
index 48e75ba9..49d2ae72 100644
--- a/src/uisupport/bufferview.cpp
+++ b/src/uisupport/bufferview.cpp
@@ -20,9 +20,11 @@
 
 #include "bufferview.h"
 
+#include "buffermodel.h"
 #include "bufferviewfilter.h"
 #include "buffersyncer.h"
 #include "client.h"
+#include "mappedselectionmodel.h"
 #include "network.h"
 #include "networkmodel.h"
 
@@ -78,11 +80,12 @@ void BufferView::init() {
 
 void BufferView::setModel(QAbstractItemModel *model) {
   delete selectionModel();
+  if(QTreeView::model()) {
+    disconnect(QTreeView::model(), SIGNAL(layoutChanged()), this, SLOT(updateSelection()));
+  }
+  
   QTreeView::setModel(model);
   init();
-  if(!model)
-    return;
-
   // remove old Actions
   QList<QAction *> oldactions = header()->actions();
   foreach(QAction *action, oldactions) {
@@ -90,6 +93,11 @@ void BufferView::setModel(QAbstractItemModel *model) {
     action->deleteLater();
   }
 
+  if(!model)
+    return;
+
+  connect(model, SIGNAL(layoutChanged()), this, SLOT(updateSelection()));
+  
   QString sectionName;
   QAction *showSection;
   for(int i = 1; i < model->columnCount(); i++) {
@@ -182,14 +190,25 @@ void BufferView::keyPressEvent(QKeyEvent *event) {
 // ensure that newly inserted network nodes are expanded per default
 void BufferView::rowsInserted(const QModelIndex & parent, int start, int end) {
   QTreeView::rowsInserted(parent, start, end);
-  if(model()->rowCount(parent) == 1 && parent.data(NetworkModel::ItemTypeRole) == NetworkModel::NetworkItemType
-     && (Global::SPUTDEV || parent.data(NetworkModel::ItemActiveRole) == true)) {
+  if(parent.data(NetworkModel::ItemTypeRole) != NetworkModel::NetworkItemType)
+    return;
+  
+  if(model()->rowCount(parent) == 1 && parent.data(NetworkModel::ItemActiveRole) == true) {
     // without updating the parent the expand will have no effect... Qt Bug?
     update(parent);
     expand(parent);
   }
 }
 
+void BufferView::updateSelection() {
+  MappedSelectionModel *mappedSelectionModel = qobject_cast<MappedSelectionModel *>(selectionModel());
+  if(!config())
+    return;
+
+  mappedSelectionModel->mappedSetCurrentIndex(Client::bufferModel()->standardSelectionModel()->currentIndex(), QItemSelectionModel::Current);
+  mappedSelectionModel->mappedSelect(Client::bufferModel()->standardSelectionModel()->selection(), QItemSelectionModel::ClearAndSelect | QItemSelectionModel::Rows);
+}
+
 void BufferView::dataChanged(const QModelIndex &topLeft, const QModelIndex &bottomRight) {
   QTreeView::dataChanged(topLeft, bottomRight);
   
diff --git a/src/uisupport/bufferview.h b/src/uisupport/bufferview.h
index 0f1b502f..6485fa5b 100644
--- a/src/uisupport/bufferview.h
+++ b/src/uisupport/bufferview.h
@@ -45,7 +45,7 @@ public:
 
   void setConfig(BufferViewConfig *config);
   inline BufferViewConfig *config() { return _config; }
-
+							       
 public slots:
   void setRootIndexForNetworkId(const NetworkId &networkId);
   
@@ -58,11 +58,13 @@ protected:
   virtual void dataChanged(const QModelIndex &topLeft, const QModelIndex &bottomRight);
   virtual void wheelEvent(QWheelEvent *);
   virtual QSize sizeHint() const;
+  virtual void focusInEvent(QFocusEvent *event) { QAbstractScrollArea::focusInEvent(event); }
 
 private slots:
   void joinChannel(const QModelIndex &index);
   void toggleHeader(bool checked);
   void showContextMenu(const QPoint &);
+  void updateSelection();
 
 private:
   QPointer<BufferViewConfig> _config;
diff --git a/version.inc b/version.inc
index 03281a3d..021ed4a2 100644
--- a/version.inc
+++ b/version.inc
@@ -4,8 +4,8 @@
 { using namespace Global;
 
   quasselVersion = "0.2.0-beta1-pre";
-  quasselDate = "2008-04-16";
-  quasselBuild = 756;
+  quasselDate = "2008-04-18";
+  quasselBuild = 777;
 
   //! Minimum client build number the core needs
   clientBuildNeeded = 731;