From: Bas Pape <baspape@gmail.com>
Date: Sat, 7 Sep 2013 11:09:06 +0000 (+0200)
Subject: Respond to CTCP PING even if it had no parameter.
X-Git-Tag: 0.10-beta1~118
X-Git-Url: https://git.quassel-irc.org/?p=quassel.git;a=commitdiff_plain;h=3e0924d45611681e470fb0c4602ce31fc844fc98;ds=sidebyside

Respond to CTCP PING even if it had no parameter.

Normally the response param is whatever came in, but e.g. qwebirc does
not send any params if the user does not explicitly specify any. This
would result in "Received unknown CTCP-PING". This patch makes quassel
respond with any empty string.
---

diff --git a/src/core/coresessioneventprocessor.cpp b/src/core/coresessioneventprocessor.cpp
index 80ea7d8d..f8fd4d70 100644
--- a/src/core/coresessioneventprocessor.cpp
+++ b/src/core/coresessioneventprocessor.cpp
@@ -1016,7 +1016,7 @@ void CoreSessionEventProcessor::handleCtcpClientinfo(CtcpEvent *e)
 
 void CoreSessionEventProcessor::handleCtcpPing(CtcpEvent *e)
 {
-    e->setReply(e->param());
+    e->setReply(e->param().isNull() ? "" : e->param());
 }