From: Sebastian Goth <seezer@roath.org>
Date: Wed, 20 Jan 2010 17:49:40 +0000 (+0100)
Subject: Don't create zombie users
X-Git-Url: https://git.quassel-irc.org/?p=quassel.git;a=commitdiff_plain;h=35967f5d2c26e6c028a4cd573c81edab350bc5ed

Don't create zombie users
---

diff --git a/src/core/ircserverhandler.cpp b/src/core/ircserverhandler.cpp
index 33445c2d..992d486e 100644
--- a/src/core/ircserverhandler.cpp
+++ b/src/core/ircserverhandler.cpp
@@ -1077,17 +1077,20 @@ void IrcServerHandler::handleNetsplitJoin(const QString &channel, const QStringL
   }
   QList<IrcUser *> ircUsers;
   QStringList newModes = modes;
+  QStringList newUsers = users;
 
   foreach(QString user, users) {
-    IrcUser *iu = network()->updateNickFromMask(user);
+    IrcUser *iu = network()->ircUser(nickFromMask(user));
     if(iu)
       ircUsers.append(iu);
-    else {
-      newModes.removeAt(users.indexOf(user));
+    else { // the user already quit
+      int idx = users.indexOf(user);
+      newUsers.removeAt(idx);
+      newModes.removeAt(idx);
     }
   }
 
-  QString msg = users.join("#:#").append("#:#").append(quitMessage);
+  QString msg = newUsers.join("#:#").append("#:#").append(quitMessage);
   emit displayMsg(Message::NetsplitJoin, BufferInfo::ChannelBuffer, channel, msg);
   ircChannel->joinIrcUsers(ircUsers, newModes);
 }