Change the order of MessageEvent ctor params
authorManuel Nickschas <sputnick@quassel-irc.org>
Thu, 30 Sep 2010 07:23:49 +0000 (09:23 +0200)
committerManuel Nickschas <sputnick@quassel-irc.org>
Wed, 13 Oct 2010 23:06:32 +0000 (01:06 +0200)
Be careful, params are specified in an order different from the old displayMsg(),
since it makes more sense like this and optimizes default arg use.

src/common/messageevent.cpp
src/common/messageevent.h

index d7f3b7c..83afcac 100644 (file)
 #include "messageevent.h"
 
 
 #include "messageevent.h"
 
 
-MessageEvent::MessageEvent(Message::Type msgType, Network *net, const QString &msg, const QString &target, const QString &sender, Message::Flags flags)
+MessageEvent::MessageEvent(Message::Type msgType, Network *net, const QString &msg, const QString &sender, const QString &target, Message::Flags flags)
     : NetworkEvent(EventManager::MessageEvent, net),
       _msgType(msgType),
       _text(msg),
     : NetworkEvent(EventManager::MessageEvent, net),
       _msgType(msgType),
       _text(msg),
-      _target(target),
       _sender(sender),
       _sender(sender),
+      _target(target),
       _msgFlags(flags)
 {
   IrcChannel *channel = network()->ircChannel(_target);
       _msgFlags(flags)
 {
   IrcChannel *channel = network()->ircChannel(_target);
index 11e9987..6938db7 100644 (file)
@@ -33,8 +33,8 @@ public:
   explicit MessageEvent(Message::Type msgType,
                         Network *network,
                         const QString &msg,
   explicit MessageEvent(Message::Type msgType,
                         Network *network,
                         const QString &msg,
-                        const QString &target = QString(),
                         const QString &sender = QString(),
                         const QString &sender = QString(),
+                        const QString &target = QString(),
                         Message::Flags msgFlags = Message::None
                         );
 
                         Message::Flags msgFlags = Message::None
                         );
 
@@ -69,7 +69,7 @@ private:
 
   Message::Type _msgType;
   BufferInfo::Type _bufferType;
 
   Message::Type _msgType;
   BufferInfo::Type _bufferType;
-  QString _text, _target, _sender;
+  QString _text, _sender, _target;
   Message::Flags _msgFlags;
 };
 
   Message::Flags _msgFlags;
 };