These cause warnings in most compilers, so remove them again until
we can use C++17 and the official attribute.
Add comments, so we know the fallthroughs are intentional anyway.
switch (e->params().count()) {
case 3:
topic = e->params()[2];
switch (e->params().count()) {
case 3:
topic = e->params()[2];
- [[clang::fallthrough]];
case 2:
userCount = e->params()[1].toUInt();
case 2:
userCount = e->params()[1].toUInt();
- [[clang::fallthrough]];
case 1:
channelName = e->params()[0];
case 1:
channelName = e->params()[0];
- [[clang::fallthrough]];
switch (e->params().count()) {
case 3:
topic = e->params()[2];
switch (e->params().count()) {
case 3:
topic = e->params()[2];
- [[clang::fallthrough]];
case 2:
userCount = e->params()[1].toUInt();
case 2:
userCount = e->params()[1].toUInt();
- [[clang::fallthrough]];
case 1:
channelName = e->params()[0];
case 1:
channelName = e->params()[0];
- [[clang::fallthrough]];
switch (query.lastError().number()) {
case 5: // SQLITE_BUSY 5 /* The database file is locked */
switch (query.lastError().number()) {
case 5: // SQLITE_BUSY 5 /* The database file is locked */
- [[clang::fallthrough]];
case 6: // SQLITE_LOCKED 6 /* A table in the database is locked */
if (retryCount < _maxRetryCount)
return safeExec(query, retryCount + 1);
case 6: // SQLITE_LOCKED 6 /* A table in the database is locked */
if (retryCount < _maxRetryCount)
return safeExec(query, retryCount + 1);
case Qt::Key_Down:
if (!(keyEvent->modifiers() & Qt::ShiftModifier))
return false;
case Qt::Key_Down:
if (!(keyEvent->modifiers() & Qt::ShiftModifier))
return false;
- [[clang::fallthrough]];
case Qt::Key_PageUp:
case Qt::Key_PageDown:
// static cast to access public qobject::event
case Qt::Key_PageUp:
case Qt::Key_PageDown:
// static cast to access public qobject::event
if (webPreview.previewItem && webPreview.previewItem->scene())
removeItem(webPreview.previewItem);
// Fall through to deletion!
if (webPreview.previewItem && webPreview.previewItem->scene())
removeItem(webPreview.previewItem);
// Fall through to deletion!
- [[clang::fallthrough]];
case WebPreview::HidePreview:
if (webPreview.previewItem) {
delete webPreview.previewItem;
case WebPreview::HidePreview:
if (webPreview.previewItem) {
delete webPreview.previewItem;
removeItem(webPreview.previewItem);
}
// fall through into to set hidden state
removeItem(webPreview.previewItem);
}
// fall through into to set hidden state
- [[clang::fallthrough]];
case WebPreview::DelayPreview:
// we're just loading, so haven't shown the preview yet.
webPreview.previewState = WebPreview::HidePreview;
case WebPreview::DelayPreview:
// we're just loading, so haven't shown the preview yet.
webPreview.previewState = WebPreview::HidePreview;
return;
case HideApplyToAll:
BufferSettings().setMessageFilter(filter);
return;
case HideApplyToAll:
BufferSettings().setMessageFilter(filter);
- [[clang::fallthrough]];
case HideUseDefaults:
if (_messageFilter)
BufferSettings(_messageFilter->idString()).removeFilter();
case HideUseDefaults:
if (_messageFilter)
BufferSettings(_messageFilter->idString()).removeFilter();
case BufferInfo::QueryBuffer:
if (regex.indexIn(_currentBufferName) > -1)
_completionMap[_currentBufferName.toLower()] = _currentBufferName;
case BufferInfo::QueryBuffer:
if (regex.indexIn(_currentBufferName) > -1)
_completionMap[_currentBufferName.toLower()] = _currentBufferName;
- [[clang::fallthrough]];
case BufferInfo::StatusBuffer:
if (!_currentNetwork->myNick().isEmpty() && regex.indexIn(_currentNetwork->myNick()) > -1)
_completionMap[_currentNetwork->myNick().toLower()] = _currentNetwork->myNick();
case BufferInfo::StatusBuffer:
if (!_currentNetwork->myNick().isEmpty() && regex.indexIn(_currentNetwork->myNick()) > -1)
_completionMap[_currentNetwork->myNick().toLower()] = _currentNetwork->myNick();