Don't return const refs from methods

This is dangerous and should be avoided where possible.

Closes GH-302.

diff --git a/src/common/peer.cpp b/src/common/peer.cpp
index 25ff814..b0eee44 100644 (file)
--- a/src/common/peer.cpp
+++ b/src/common/peer.cpp
@@ -33,7 +33,7 @@ AuthHandler *Peer::authHandler() const
     return _authHandler;
 }
 
     return _authHandler;
 }
 

-const QDateTime &Peer::connectedSince() const {
+QDateTime Peer::connectedSince() const {

     return _connectedSince;
 }
 
     return _connectedSince;
 }
 


@@ -41,7 +41,7 @@ void Peer::setConnectedSince(const QDateTime &connectedSince) {
     _connectedSince = connectedSince;
 }
 
     _connectedSince = connectedSince;
 }
 

-const QString &Peer::buildDate() const {
+QString Peer::buildDate() const {

     return _buildDate;
 }
 
     return _buildDate;
 }
 


@@ -49,7 +49,7 @@ void Peer::setBuildDate(const QString &buildDate) {
     _buildDate = buildDate;
 }
 
     _buildDate = buildDate;
 }
 

-const QString &Peer::clientVersion() const {
+QString Peer::clientVersion() const {

     return _clientVersion;
 }
 
     return _clientVersion;
 }
 

diff --git a/src/common/peer.h b/src/common/peer.h
index 6b824cf..64a333c 100644 (file)
--- a/src/common/peer.h
+++ b/src/common/peer.h
@@ -42,13 +42,13 @@ public:
     virtual SignalProxy *signalProxy() const = 0;
     virtual void setSignalProxy(SignalProxy *proxy) = 0;
 
     virtual SignalProxy *signalProxy() const = 0;
     virtual void setSignalProxy(SignalProxy *proxy) = 0;
 

-    const QDateTime &connectedSince() const;
+    QDateTime connectedSince() const;

     void setConnectedSince(const QDateTime &connectedSince);
 
     void setConnectedSince(const QDateTime &connectedSince);
 

-    const QString &buildDate() const;
+    QString buildDate() const;

     void setBuildDate(const QString &buildDate);
 
     void setBuildDate(const QString &buildDate);
 

-    const QString &clientVersion() const;
+    QString clientVersion() const;

     void setClientVersion(const QString &clientVersion);
 
     int id() const;
     void setClientVersion(const QString &clientVersion);
 
     int id() const;