Properly register the Network::ConnectionState enum
authorManuel Nickschas <sputnick@quassel-irc.org>
Tue, 27 Mar 2012 20:02:21 +0000 (22:02 +0200)
committerManuel Nickschas <sputnick@quassel-irc.org>
Tue, 22 May 2012 19:54:50 +0000 (21:54 +0200)
The Q_ENUMS declaration was, uhm, creative, and additionally Q_ENUMS are automatically
registered with the QMetaType system, so no need for registering them again. Actually,
while this somehow works in Qt4, Qt5 barfs with an assert.

src/common/network.h
src/common/quassel.cpp

index c202ede..6b126d8 100644 (file)
@@ -47,7 +47,7 @@ struct NetworkInfo;
 class Network : public SyncableObject {
   SYNCABLE_OBJECT
   Q_OBJECT
-  Q_ENUMS(ConnectionState Network::ConnectionState)
+  Q_ENUMS(ConnectionState)
 
   Q_PROPERTY(QString networkName READ networkName WRITE setNetworkName STORED false)
   Q_PROPERTY(QString currentServer READ currentServer WRITE setCurrentServer STORED false)
index db56043..eb854b3 100644 (file)
@@ -161,14 +161,12 @@ void Quassel::registerMetaTypes() {
   qRegisterMetaType<NetworkInfo>("NetworkInfo");
   qRegisterMetaType<Network::Server>("Network::Server");
   qRegisterMetaType<Identity>("Identity");
-  qRegisterMetaType<Network::ConnectionState>("Network::ConnectionState");
 
   qRegisterMetaTypeStreamOperators<Message>("Message");
   qRegisterMetaTypeStreamOperators<BufferInfo>("BufferInfo");
   qRegisterMetaTypeStreamOperators<NetworkInfo>("NetworkInfo");
   qRegisterMetaTypeStreamOperators<Network::Server>("Network::Server");
   qRegisterMetaTypeStreamOperators<Identity>("Identity");
-  qRegisterMetaTypeStreamOperators<qint8>("Network::ConnectionState");
 
   qRegisterMetaType<IdentityId>("IdentityId");
   qRegisterMetaType<BufferId>("BufferId");