ci: Workaround macOS hdiutil out of space errors
authorShane Synan <digitalcircuit36939@gmail.com>
Mon, 9 Nov 2020 04:21:49 +0000 (23:21 -0500)
committerManuel Nickschas <sputnick@quassel-irc.org>
Sat, 21 Nov 2020 14:53:28 +0000 (15:53 +0100)
commitf09a86ab1cc01a80aa6fd52a875920e18d1d3a5b
treec55743faf53409ba0f2586d9a93160e6764ea0c2
parent1868486419b5354a7a2e45b263a0b698ab51e83c
ci: Workaround macOS hdiutil out of space errors

Workaround "hdiutil: create failed - No space left on device" by
letting hdiutil auto-detect the required disk space.  Keep the old
method around via documentation in case this issue arises again.

https://stackoverflow.com/questions/18621467/error-creating-disk-image-using-hdutil
https://apple.stackexchange.com/questions/156994/yosemite-hdiutil-create-failed-error-5341
https://asmaloney.com/2013/07/howto/packaging-a-mac-os-x-application-using-a-dmg/
https://github.com/autopkg/jps3-recipes/issues/57

Make this issue easier to detect by changing the build script
macosx_makePackage.sh to fail early if any individual command fails.
This includes fixing up optional parameters to use default values.

Re-enable the "Check artifacts" step of the "Post-Build" process now
that macOS builds are hopefully more reliable.
.github/workflows/main.yml
scripts/build/macosx_makePackage.sh