sigproxy: Actually rename SyncableObjects when requested
authorManuel Nickschas <sputnick@quassel-irc.org>
Wed, 17 Oct 2018 20:14:24 +0000 (22:14 +0200)
committerManuel Nickschas <sputnick@quassel-irc.org>
Sun, 18 Nov 2018 10:06:43 +0000 (11:06 +0100)
commitb8ce41ef6c0036d854f5bef0fb52e2a69dc5def2
tree8ba35a9a745775a2792169bb20961c911f975031
parent96e623bcd9a56fdf153a6c82376a9ab0c45aa102
sigproxy: Actually rename SyncableObjects when requested

Until now, renaming a SyncableObject would properly update the maps
in SignalProxy, but it would not actually update the objectName
property on the client side. Fix this.

Remove the renameObject() method in SyncableObject in favor of
using setObjectName() and listening to the notifier signal emitted
by Qt for triggering the update. This ensures that the actual object
name and the expected one stay in sync. Also change places where
we unnecessarily rename right after construction to use the
appropriate constructor instead.

Extend the test case to cover the renaming of SyncableObject.
src/common/dccconfig.cpp
src/common/identity.cpp
src/common/ircuser.cpp
src/common/signalproxy.cpp
src/common/syncableobject.cpp
src/common/syncableobject.h
src/common/transfer.cpp
src/common/transfermanager.cpp
src/core/coreidentity.cpp
tests/common/signalproxytest.cpp