modernize: Replace most remaining old-style connects by PMF ones
authorManuel Nickschas <sputnick@quassel-irc.org>
Wed, 12 Sep 2018 17:45:13 +0000 (19:45 +0200)
committerManuel Nickschas <sputnick@quassel-irc.org>
Sun, 18 Nov 2018 10:06:43 +0000 (11:06 +0100)
commit6eefdfc697067d184a589fc8a231b16316c09106
tree0222fd1674d3ef72fc4da2988f5ed8a031a5cacc
parent42ab7cc22c4702716db2b8bfa1d4545169f772e6
modernize: Replace most remaining old-style connects by PMF ones

Manually replace old-style connects (using the SIGNAL/SLOT macros)
by the much more efficient and typesafe pointer-to-member-function-
based ones.

This fixes the cases where clazy could not auto-migrate to the new
syntax for a variety of reasons. In most of the cases, we need to
remove overloads or explicitly select the desired one, because the
plain syntax cannot deal with overloads. Another issue is trying
to connect to signals in a baseclass that are only declared in a
derived class (which works with the old-style runtime connection
handling, but obviously no longer with the compile-time version).

Also do some selected cleanups in places.
96 files changed:
src/client/abstractmessageprocessor.h
src/client/bufferviewoverlay.cpp
src/client/client.cpp
src/client/clientauthhandler.cpp
src/client/coreconnection.cpp
src/client/coreconnection.h
src/client/execwrapper.cpp
src/client/networkmodel.cpp
src/common/authhandler.cpp
src/common/compressor.cpp
src/common/internalpeer.cpp
src/common/ircchannel.cpp
src/common/ircchannel.h
src/common/posixsignalwatcher.cpp
src/common/protocols/legacy/legacypeer.h
src/common/quassel.cpp
src/common/remotepeer.cpp
src/common/remotepeer.h
src/core/core.cpp
src/core/core.h
src/core/coreapplication.cpp
src/core/coreauthhandler.cpp
src/core/corebasichandler.cpp
src/core/corebasichandler.h
src/core/corenetwork.cpp
src/core/corenetwork.h
src/core/coresession.cpp
src/core/coresession.h
src/core/coretransfer.cpp
src/core/sessionthread.cpp
src/main/monoapplication.cpp
src/qtui/awaylogview.cpp
src/qtui/bufferwidget.cpp
src/qtui/chatitem.cpp
src/qtui/chatmonitorview.cpp
src/qtui/chatviewsearchbar.cpp
src/qtui/chatviewsearchcontroller.cpp
src/qtui/columnhandleitem.cpp
src/qtui/coreconfigwizard.cpp
src/qtui/coreconnectdlg.cpp
src/qtui/coreinfodlg.cpp
src/qtui/coresessionwidget.cpp
src/qtui/coresessionwidget.h
src/qtui/debugbufferviewoverlay.cpp
src/qtui/dockmanagernotificationbackend.cpp
src/qtui/inputwidget.cpp
src/qtui/knotificationbackend.cpp
src/qtui/mainwin.cpp
src/qtui/nicklistwidget.cpp
src/qtui/nicklistwidget.h
src/qtui/osxnotificationbackend.mm
src/qtui/qtui.cpp
src/qtui/qtuiapplication.cpp
src/qtui/qtuimessageprocessor.cpp
src/qtui/qtuimessageprocessor.h
src/qtui/settingsdlg.cpp
src/qtui/settingspagedlg.cpp
src/qtui/settingspages/aliasesmodel.cpp
src/qtui/settingspages/aliasesmodel.h
src/qtui/settingspages/aliasessettingspage.cpp
src/qtui/settingspages/appearancesettingspage.cpp
src/qtui/settingspages/backlogsettingspage.cpp
src/qtui/settingspages/bufferviewsettingspage.cpp
src/qtui/settingspages/chatmonitorsettingspage.cpp
src/qtui/settingspages/coreaccountsettingspage.cpp
src/qtui/settingspages/corehighlightsettingspage.cpp
src/qtui/settingspages/dccsettingspage.cpp
src/qtui/settingspages/highlightsettingspage.cpp
src/qtui/settingspages/identitiessettingspage.cpp
src/qtui/settingspages/identityeditwidget.cpp
src/qtui/settingspages/ignorelistmodel.cpp
src/qtui/settingspages/ignorelistmodel.h
src/qtui/settingspages/ignorelistsettingspage.cpp
src/qtui/settingspages/ignorelistsettingspage.h
src/qtui/settingspages/itemviewsettingspage.cpp
src/qtui/settingspages/networkssettingspage.cpp
src/qtui/settingspages/notificationssettingspage.cpp
src/qtui/settingspages/shortcutsmodel.cpp
src/qtui/settingspages/shortcutsmodel.h
src/qtui/settingspages/shortcutssettingspage.cpp
src/qtui/snorenotificationbackend.cpp
src/qtui/snorenotificationbackend.h
src/qtui/sslinfodlg.cpp
src/qtui/statusnotifieritem.cpp
src/qtui/statusnotifieritemdbus.h
src/qtui/systraynotificationbackend.cpp
src/qtui/systraynotificationbackend.h
src/qtui/taskbarnotificationbackend.cpp
src/uisupport/abstractnotificationbackend.h
src/uisupport/action.cpp
src/uisupport/bufferview.cpp
src/uisupport/bufferviewfilter.cpp
src/uisupport/nickview.cpp
src/uisupport/settingspage.h
src/uisupport/toolbaractionprovider.cpp
src/uisupport/toolbaractionprovider.h