modernize: Pass arguments by value and move in constructors
authorManuel Nickschas <sputnick@quassel-irc.org>
Thu, 6 Sep 2018 19:01:22 +0000 (21:01 +0200)
committerManuel Nickschas <sputnick@quassel-irc.org>
Sun, 18 Nov 2018 10:06:43 +0000 (11:06 +0100)
commit3a3e844f9fcfd12235a0086af75ecd503b621ef4
treecfc53f13e1f7b985f6d051d6c0b7a155ba2d44c4
parent80950b87640acfb2a75902f8aabf3419da094bf4
modernize: Pass arguments by value and move in constructors

If a method (or constructor) wants to store an argument in a local
variable or attribute, one should prefer passing it in by value
and moving it into the final location, rather than taking a
const reference and copying it over. In the best case, this saves
one copy, if the method is called with an rvalue.

This pattern is most frequent in constructors initializing class
members, so let clang-tidy fix this for argument types that have
move constructors.
49 files changed:
src/client/clientsettings.cpp
src/client/clientsettings.h
src/client/networkmodel.cpp
src/client/networkmodel.h
src/client/treemodel.cpp
src/client/treemodel.h
src/common/aliasmanager.h
src/common/basichandler.cpp
src/common/basichandler.h
src/common/bufferinfo.cpp
src/common/buffersyncer.cpp
src/common/buffersyncer.h
src/common/ctcpevent.h
src/common/highlightrulemanager.h
src/common/ignorelistmanager.h
src/common/ircevent.h
src/common/irclisthelper.h
src/common/message.cpp
src/common/message.h
src/common/messageevent.cpp
src/common/messageevent.h
src/common/network.h
src/common/networkevent.h
src/common/protocol.h
src/common/settings.h
src/common/signalproxy.cpp
src/common/transfer.cpp
src/common/transfer.h
src/core/coresession.h
src/core/coreuserinputhandler.h
src/core/ctcpparser.h
src/core/keyevent.h
src/qtui/chatitem.h
src/qtui/chatscene.cpp
src/qtui/chatscene.h
src/qtui/qtuimessageprocessor.h
src/qtui/settingspages/bufferviewsettingspage.cpp
src/qtui/settingspages/bufferviewsettingspage.h
src/qtui/settingspages/identitiessettingspage.cpp
src/qtui/settingspages/identityeditwidget.h
src/qtui/settingspages/networkssettingspage.cpp
src/qtui/settingspages/networkssettingspage.h
src/uisupport/aboutdata.cpp
src/uisupport/aboutdata.h
src/uisupport/abstractnotificationbackend.h
src/uisupport/settingspage.cpp
src/uisupport/settingspage.h
src/uisupport/uisettings.cpp
src/uisupport/uisettings.h