core: AutoWhoX, only search nickname by nickname
authorShane Synan <digitalcircuit36939@gmail.com>
Thu, 13 Sep 2018 07:00:17 +0000 (02:00 -0500)
committerManuel Nickschas <sputnick@quassel-irc.org>
Thu, 13 Sep 2018 21:46:02 +0000 (23:46 +0200)
commitcdc6091a2e02b84a48937cda287a0769ceb8726a
tree82772d9cac1102ae3265f8835bde8a4d32db1f57
parent6d66d7ed0184f356b9a0c724e9ced2ee819b8693
core: AutoWhoX, only search nickname by nickname

When running automatic WhoX, explicitly specify "n" to search by
nickname only.  Don't rely on server defaults.  This fixes an issue
with Quassel's autoWHO causing noise in the Status Buffer uncovered
by InspIRCd 3.0's implementation of WhoX that follows the spec.

Fix up incorrect attempt to escape "%" as "%%".  Apparently,
QString::arg() doesn't need to escape this.

Before: WHO <nickname> %%chtsunfra,<unique_number>
After:  WHO <nickname> n%chtsunfra,<unique_number>

See https://github.com/quakenet/snircd/blob/master/doc/readme.who
And https://doc.qt.io/qt-5/qstring.html#arg

Thanks to @genius3000 for reporting and tracking down this issue!

Fixes #1487
src/core/corenetwork.cpp